Use orientationIndex enum from header#21550
Merged
sbc100 merged 6 commits intoemscripten-core:mainfrom Mar 19, 2024
Merged
Conversation
Collaborator
Author
|
Failures seem to be down to changes in |
sbc100
reviewed
Mar 18, 2024
sbc100
reviewed
Mar 18, 2024
sbc100
approved these changes
Mar 18, 2024
8c0583e to
4a66a13
Compare
Collaborator
Author
|
Note to a future me, because this will trip me up again in six months... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #21428 the enum value was taken from the header.
In the process, since adding to
struct_info.jsonwas needed, a fix to the reported path prompting to rungen_struct_info.pywas added.