Ifdef wasmBinaryFile assignment from SINGLE_FILE builds.#21587
Merged
juj merged 1 commit intoemscripten-core:mainfrom Mar 26, 2024
Merged
Ifdef wasmBinaryFile assignment from SINGLE_FILE builds.#21587juj merged 1 commit intoemscripten-core:mainfrom
juj merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
reviewed
Mar 21, 2024
| if (Module['locateFile']) { | ||
| #endif | ||
| wasmBinaryFile = '{{{ WASM_BINARY_FILE }}}'; | ||
| #if !SINGLE_FILE |
Collaborator
There was a problem hiding this comment.
I suppose this is because we know a priori that wasmBinaryFile is a data URI in this mode?
Collaborator
There was a problem hiding this comment.
Does this not change any of our code size expectations?
Collaborator
Author
There was a problem hiding this comment.
I suppose this is because we know a priori that
wasmBinaryFileis a data URI in this mode?
Yeah, that's right. In SINGLE_FILE builds the Wasm content is embedded, so locateFile is not needed.
Does this not change any of our code size expectations?
Looks like not, CI shows green.
sbc100
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spliced from #21478 (comment)