[embind] Always enable assertions during TypeScript generation.#21695
[embind] Always enable assertions during TypeScript generation.#21695brendandahl merged 6 commits intoemscripten-core:mainfrom
Conversation
cb06945 to
0483145
Compare
tools/link.py
Outdated
| settings.SINGLE_FILE = False | ||
| # Embind may be included multiple times, de-duplicate the list first. | ||
| settings.JS_LIBRARIES = dedup_list(settings.JS_LIBRARIES) | ||
| # Assertions are always used. |
|
Something changed so now when assertions are enabled |
|
I guess this was #21172. Maybe instead of relying on |
Unless you are in strict mode |
Yeah, the original issue filed above was using |
|
Or I guess I can do ifdefs like all the other library code. |
| argStart = 2; | ||
| } | ||
| #if ASSERTIONS | ||
| if (argsName.length) |
There was a problem hiding this comment.
Can you add curly braces around the if body ?
Fixes #21641