Remove special case for memory import. NFC#21818
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 24, 2024
Merged
Conversation
This is no longer needed since emscripten-core#21701 landed
dschuff
approved these changes
Apr 24, 2024
| extra_sent_items.append('alignfault') | ||
|
|
||
| # Special case for importing memory and table | ||
| # TODO(sbc): can we make these into normal library symbols? |
Member
There was a problem hiding this comment.
Are there symbol types for memories?
Collaborator
Author
There was a problem hiding this comment.
Yes, we could add memories and tables to this list:
Line 2904 in b760788
My initial attempt to do that didn't work but I hope to figure it out at some point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer needed since #21701 landed