getsockopt mismatch in websocket_to_posix_proxy vs. _socket#22432
Open
stbergmann wants to merge 2 commits intoemscripten-core:mainfrom
Open
getsockopt mismatch in websocket_to_posix_proxy vs. _socket#22432stbergmann wants to merge 2 commits intoemscripten-core:mainfrom
stbergmann wants to merge 2 commits intoemscripten-core:mainfrom
Conversation
It appears that ever since 31309a8 "full_posix_sockets (emscripten-core#7672)", the _proxy side sent back a result that included an explicit option_len while the _socket side computes that value from the overall result size.
Collaborator
|
@juj WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that ever since 31309a8 "full_posix_sockets (#7672)", the _proxy side sent back a result that included an explicit option_len while the _socket side computes that value from the overall result size.