Stop generating empty .worker.js in pthreads builds#22598
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Sep 20, 2024
Merged
Stop generating empty .worker.js in pthreads builds#22598sbc100 merged 1 commit intoemscripten-core:mainfrom
.worker.js in pthreads builds#22598sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
worker_js
branch
2 times, most recently
from
5229c5b to
d9b33dd
Compare
dschuff
approved these changes
Sep 20, 2024
kripken
reviewed
Sep 20, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Please mention this in the changelog.
We stopped using a separate worker file back in emscripten-core#21701. That was released in 3.1.58 back in April. This change ends the transition period by no longer generating a dummy/useless worker.js file alongside the output.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 22, 2025
The unused argument in test_export_es6 should have been removed as part of emscripten-core#22598.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 22, 2025
The unused argument in test_export_es6 should have been removed as part of emscripten-core#22598.
sbc100
added a commit
that referenced
this pull request
Jan 22, 2025
The unused argument in test_export_es6 should have been removed as part of #22598.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We stopped using a separate worker file back in #21701. That was released in 3.1.58 back in April.
This change ends the transition period by no longer generating a dummy/useless worker.js file alongside the output.