Consistent use of arrow functions in JS library code. NFC#22807
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Oct 30, 2024
Merged
Consistent use of arrow functions in JS library code. NFC#22807sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
arrow_functions
branch
from
c7d733e to
e9ce96c
Compare
sbc100
force-pushed
the
arrow_functions
branch
from
e9ce96c to
da84fc2
Compare
kripken
reviewed
Oct 30, 2024
| this.status = status; | ||
| $ExitStatus: class { | ||
| name = 'ExitStatus'; | ||
| constructor(status) { |
Member
There was a problem hiding this comment.
This does more than use arrow functions? Was it part of another PR?
Collaborator
Author
There was a problem hiding this comment.
Yeah, sorry this should have been part of #22808
sbc100
force-pushed
the
arrow_functions
branch
from
da84fc2 to
c042cb6
Compare
kripken
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.