[AUDIO_WORKLET] Fix spinlocks for audio worklets (and add tests)#23393
Closed
cwoffenden wants to merge 3 commits intoemscripten-core:mainfrom
Closed
[AUDIO_WORKLET] Fix spinlocks for audio worklets (and add tests)#23393cwoffenden wants to merge 3 commits intoemscripten-core:mainfrom
cwoffenden wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
a5a9dc2 to
84eee0a
Compare
Collaborator
Author
|
Odd, GH closed this when I renamed the branch to merge into a fork (it's residing in cw-audio-spinlock-fix). If there's any interest in this I can re-open another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #22962. In brief:
This is an update to #22995 which had become hard to track. The spinlocks are moved to using
emscripten_get_now()so they can be used in Audio Worklets, and a set of interactive tests added for the spinlock use cases.The test can be run with:
Or standalone with:
I can change the other
emscripten_performance_now()calls toemscripten_get_now()(as suggested in #22995) in a separate PR.