Add support for locateFile() to Audio Worklets and add a test. Fixes #20318.#24044
Closed
juj wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Add support for locateFile() to Audio Worklets and add a test. Fixes #20318.#24044juj wants to merge 1 commit intoemscripten-core:mainfrom
juj wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
approved these changes
Apr 3, 2025
sbc100
reviewed
Apr 3, 2025
| locateFile: function(path, prefix) { | ||
| return path.includes('.aw.js') ? 'subdir/' + path : path; | ||
| }, | ||
| ''')) |
Collaborator
There was a problem hiding this comment.
I don't think this requires a custom shell.html.
I think you can just put the Module = { ... } stuff in a --pre-js file there.
|
hey guys, i'd love to see this supported! i keep all emscripten-compiled files outside the root directory. |
Collaborator
|
Looks like this just needs a rebase. @juj can you take a look? |
Collaborator
Author
|
This is obsoleted by PR #24190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for locateFile() to Audio Worklets and add a test. Fixes #20318.