Simplify AUDIO_WORKLET checks. NFC

[sbc100]

I assume the idea here was that there would be an AUDIO_WORKLET=2 mode but that was never added.

[sbc100]

@cwoffenden

[kripken]

Is this a separate change?

[sbc100]

No, its just an internal setting that is no longer needed after this change.

[cwoffenden]

I assume the idea here was that there would be an AUDIO_WORKLET=2 mode but that was never added.

I did useAUDIO_WORKLET=2 for the updated API I had in development, but I think it better to run the two side-by-side marking parts with __attribute__((deprecated)).

Removing the need for a custom AUDIO_WORKLET_FILE makes sense.

[juj]

I recall I would have originally intended AUDIO_WORKLET=2 to be used for an embedded mode where the file a.aw.js would be emdedded into the main JS (like with Wasm Workers). It is a tradeoff between CSP-eval policy safety to choose whether to embed the file, or have it separate.

But this change LGTM, I presume we can still add a AUDIO_WORKLET=2 mode later if we wanted to.

[sbc100]

I recall I would have originally intended AUDIO_WORKLET=2 to be used for an embedded mode where the file a.aw.js would be emdedded into the main JS (like with Wasm Workers). It is a tradeoff between CSP-eval policy safety to choose whether to embed the file, or have it separate.

But this change LGTM, I presume we can still add a AUDIO_WORKLET=2 mode later if we wanted to.

Yup, that makes sense to me.

BTW, for wasm workers I'm looking at removed completely the separate .ww.js file now: #24163

[sbc100]

Can someone lgtm?