Disallow -sWASM_WORKERS with sanitizers#24171
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 23, 2025
Merged
Conversation
kripken
approved these changes
Apr 22, 2025
Back in emscripten-core#21701 I broke move the creation of wasmOffsetConvert and wasmOffset into runtime_pthread.js but I didn't update libwasm_worker.js which still uses the old name `wasmOffsetData` in its initial post message. When trying to update this just now I noticed that the offset converter (and santiizers in general) don't seem to work on WASM_WORKERS so this change simply disables them.
sbc100
force-pushed
the
wasm_workers_sanitize
branch
from
8f48741 to
02e8bf5
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 29, 2025
This configuration was recently marked as unsupported (emscripten-core#24171)
sbc100
added a commit
that referenced
this pull request
Apr 29, 2025
This configuration was recently marked as unsupported (#24171)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in #21701 I moved the creation of wasmOffsetConvert and wasmOffset into runtime_pthread.js but I didn't update libwasm_worker.js which still uses the old name
wasmOffsetDatain its initial post message.When trying to update this just now I noticed that the offset converter (and santiizers in general) don't seem to work on
WASM_WORKERSso this change simply disables them.The passing of
wasmOffsetDataandwasmSourceMapDatawas added back in #20188 but it doesn't looks like support for santizers was supposed to be part of that.