Fix = vs == typos in test assertions. NFC#24194
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 28, 2025
Merged
Conversation
sbc100
force-pushed
the
fix_assert
branch
2 times, most recently
from
e9074e2 to
fcfaa97
Compare
Member
Maybe land the others and open an issue for the failing ones? |
I first noticed a type in audioworklet_params_mixing.c from emscripten-core#23659 then found several other tests with the same issue. Nasty. Not sure what to do about the test_sdl_set_clip_rect assertions which don't seem to be valid (i.e. they fail with the typo fixed).
Collaborator
Author
I created a bug to look into it #24201 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I first noticed a type in audioworklet_params_mixing.c from #23659 then found several other tests with the same issue. Nasty.
Not sure what to do about the test_sdl_set_clip_rect assertions which don't seem to be valid (i.e. they fail with the typo fixed).