Update feature matrix to highlight unconditionally required DedicatedWorkerGlobalScope.name parameter.#24933
Conversation
…WorkerGlobalScope.name parameter.
tools/feature_matrix.py
Outdated
| OLDEST_SUPPORTED_SAFARI = 101000 # September 20, 2016 | ||
| OLDEST_SUPPORTED_CHROME = 70 # October 16, 2018 | ||
| OLDEST_SUPPORTED_FIREFOX = 55 # August 08, 2017 | ||
| OLDEST_SUPPORTED_SAFARI = 120200 # March 25, 2019 |
There was a problem hiding this comment.
These need to be kept in sync with the docs in for MIN_CHROME_VERSION etc in src/settings.js I think.
(Can you update comment above to mention this too)
There was a problem hiding this comment.
The src/settings.js min_*_version fields are already newer than these.
There was a problem hiding this comment.
I meant in the comments. e.g.:
// Minimum supported value is 55, which was released on 2016-12-01 (see
// feature_matrix.py).
(these comments regarding the min versions would need updating).
Thats only true for users using pthreads or wasm workers I think though? Those users are already tend to be targetting more recent browers anyway. For users targetting legacy browsers its unlikely they will be expecting pthreads to work. |
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Seems reasonable to me. 2019 is still 6 years ago, our default is significantly newer, and I don't recall people complaining about these bumps. (And people can always use older Emscripten versions.)
| // see https://github.com/emscripten-core/emscripten/pull/7191. | ||
| // MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported. | ||
| // Minimum supported value is 101000 which was released in 2016-09 (see | ||
| // Minimum supported value is 120200 which was released on 2019-03-25 (see |
There was a problem hiding this comment.
The rest of the comment above might need updates too. "14.1" should be 15, unrelated to this PR though. And iPhone 4s should be 5 based on the PR description?
There was a problem hiding this comment.
Added a second note to specifically list multithreaded code, since the above refers to singlethreaded code.
|
Codesize failures will be fixed by rebase/merge I believe. |
|
I'm excited to make some cleanups once this lands.. but maybe will wait a release or two to see if there is feedback. |
Cool. I was thinking maybe multithreading in general might be one feature to use the Feature mechanism for, if we wanted to distinguish singlethreaded vs multithreaded support rigorously. |
Since emscripten-core#24933 there are now certain comparisons which can be removed since they are always false.
…WorkerGlobalScope.name parameter. (emscripten-core#24933) Way back I recall I did not want to target Worker's `name` parameter given it had browser version requirements, and listed to be a [debugging feature](https://html.spec.whatwg.org/multipage/workers.html#dom-worker-dev). Though now that we have crossed that line, update minimum browser version feature matrix to require `name` support (e.g. after emscripten-core#24190), up[date the minimum required browser versions to highlight this fact. We could maintain separate min required versions for singlethreaded and multithreaded builds, although given that the minimum browser version bump here is relatively small, probably no bother. Although the version bump does mean that Emscripten does no longer support iPhone 5 devices. Fortunately they are very old by now, so practically absent.
…mscripten-core#25177) Since emscripten-core#24933 there are now certain comparisons which can be removed since they are always false.
3 participants
Way back I recall I did not want to target Worker's
nameparameter given it had browser version requirements, and listed to be a debugging feature.Though now that we have crossed that line, update minimum browser version feature matrix to require
namesupport (e.g. after #24190), up[date the minimum required browser versions to highlight this fact.We could maintain separate min required versions for singlethreaded and multithreaded builds, although given that the minimum browser version bump here is relatively small, probably no bother.
Although the version bump does mean that Emscripten does no longer support iPhone 5 devices. Fortunately they are very old by now, so practically absent.