Add some testing of the emscripten_condvar API. NFC#26456
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 16, 2026
Merged
Add some testing of the emscripten_condvar API. NFC#26456sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
condvar_testing
branch
3 times, most recently
from
0145162 to
c77a19d
Compare
kripken
approved these changes
Mar 16, 2026
| } | ||
| // At this point we know the waiter took the lock already. | ||
| // That means that once we acquire the lock here the waiter | ||
| // muste be `emscripten_condvar_waitinf`. |
Member
There was a problem hiding this comment.
Suggested change
| // muste be `emscripten_condvar_waitinf`. | |
| // must be `emscripten_condvar_waitinf`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think these were forgotten when Wasm Workers were first added in #12833