Skip to content

remove_trailing_whitespaces#5469

Closed
juj wants to merge 1 commit intoemscripten-core:incomingfrom
juj:remove_trailing_whitespaces
Closed

remove_trailing_whitespaces#5469
juj wants to merge 1 commit intoemscripten-core:incomingfrom
juj:remove_trailing_whitespaces

Conversation

@juj
Copy link
Collaborator

@juj juj commented Aug 14, 2017

Remove trailing whitespaces on a number of .py, .js and .rst files in the repository.

This was motivated by #5464 (comment)

Done by running sed -i '' -e's/[[:space:]]*$//' "$1" on the input files.

@juj
Copy link
Collaborator Author

juj commented Aug 14, 2017

Actually, I am not sure if this is worth it, unless we had some kind of git pre-commit warn/error hook in place to make sure we are clean from trailing whitespaces. This is quite pedantic in practice, and we might just want to close without merging.

@juj juj mentioned this pull request Aug 14, 2017
3 tasks
@nazar-pc
Copy link
Contributor

Yeah, a lot of changes. It all depends on you, maintainers, whether you want this or not. My IDE is hardly configured to remove any trailing spaces automatically and add a new line at the end of the file if there is none.

So it makes it a bit difficult to me to restore whitespaces before commit, but I'll align with whatever decision you make.

I'm pretty sure you can add something like Travis CI and make a check on each incoming PR whether it conforms to the rules you'd like it to conform. This way even if not everyone have pre-commit hook added, you can still avoid merging something that introduces new redundant whitespaces.

@juj
Copy link
Collaborator Author

juj commented Nov 1, 2018

Closing this, not useful.

@juj juj closed this Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants