Skip to content

Multithreading 8/N: Add support to calling OpenAL from pthreads#5533

Merged
juj merged 1 commit intoemscripten-core:incomingfrom
juj:openal_in_pthreads
Nov 10, 2017
Merged

Multithreading 8/N: Add support to calling OpenAL from pthreads#5533
juj merged 1 commit intoemscripten-core:incomingfrom
juj:openal_in_pthreads

Conversation

@juj
Copy link
Collaborator

@juj juj commented Aug 26, 2017

Similar to #5532, this extends OpenAL API to be coherently visible in all running threads.

We may want to defer landing this until I have had time to address #5367, since these will overlap. Redoing this PR is quite easy, so can layer this on top of #5367 after it is taken care of.

@juj
Copy link
Collaborator Author

juj commented Aug 26, 2017

This will need #5531 to land first.

@jpernst
Copy link
Contributor

jpernst commented Aug 26, 2017

Interesting. Is there a way to detect which thread a request has been proxied from? If so, I could use that to implement ALC_EXT_thread_local_context after this lands for more GL-like context behavior.

@juj
Copy link
Collaborator Author

juj commented Aug 27, 2017

Interesting. Is there a way to detect which thread a request has been proxied from?

Actually, yes! That kind of mechanism will be introduced in a couple of PRs later, where it is needed for other purposes as well. JS code will be able to detect if they are currently processing a proxied call on behalf of another thread, and get the thread pointer of the thread they are performing the call for.

@juj juj force-pushed the openal_in_pthreads branch from 824402f to f4e5178 Compare September 8, 2017 08:51
@kripken
Copy link
Member

kripken commented Sep 12, 2017

lgtm

for this and the SDL one, can we add a pthreads test?

@juj
Copy link
Collaborator Author

juj commented Sep 13, 2017

for this and the SDL one, can we add a pthreads test?

Yeah, I'll mark that down as a followup, since I'm juggling some 20 branches here at the moment.

@juj juj force-pushed the openal_in_pthreads branch from f4e5178 to dafb738 Compare November 10, 2017 14:27
@juj juj merged commit 1a13249 into emscripten-core:incoming Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants