OpenAL: don't overflow an array on alGetSourcei(AL_BUFFER).#5612
Closed
icculus wants to merge 1 commit intoemscripten-core:incomingfrom
icculus:incoming
Closed
OpenAL: don't overflow an array on alGetSourcei(AL_BUFFER).#5612icculus wants to merge 1 commit intoemscripten-core:incomingfrom icculus:incoming
icculus wants to merge 1 commit intoemscripten-core:incomingfrom
icculus:incoming
Conversation
This happens if you have a source with a completely processed buffer queue; the query will dereference index src.buffersPlayed, which is equal to the src.queue.length.
Collaborator
Contributor
Author
|
It looks like #5367 has a different (but more correct) behavior that eliminates this bug, so I think we're good here; disregard my patch! |
Collaborator
|
Perfect, let's close this one then as resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens if you have a source with a completely processed buffer queue;
the query will dereference index src.buffersPlayed, which is equal to the
src.queue.length.