Fix the dodgy call_sync_on_main_thread tests #8621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
May 16, 2019
Member
|
Thanks @VirtualTim! |
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
Previously these tests weren't actually checking the right thing. This should fix the logic to what I think the author was trying to do. Fixes emscripten-core#8620.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Previously these tests weren't actually checking the right thing. This should fix the logic to what I think the author was trying to do. Fixes emscripten-core#8620.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these tests weren't actually checking the right thing. This should fix the logic to what I think the author was trying to do.
Fixes #8620.