Skip to content

Migrate Closure to be shipped via emsdk or manually installed via npm.#9986

Closed
juj wants to merge 1 commit intoemscripten-core:incomingfrom
juj:closure_via_emsdk
Closed

Migrate Closure to be shipped via emsdk or manually installed via npm.#9986
juj wants to merge 1 commit intoemscripten-core:incomingfrom
juj:closure_via_emsdk

Conversation

@juj
Copy link
Collaborator

@juj juj commented Dec 7, 2019

This removes Closure from the tree, and migrates it to be installed by running one of:

npm install -g google-closure-compiler (in any directory)
npm install google-closure-compiler (in Emscripten root directory)
emsdk install latest (all releases get closure by default)
emsdk install closure-compiler-20191111 (explicit install of the Tool)

Needs emscripten-core/emsdk#403 to land first.

@juj juj mentioned this pull request Dec 7, 2019
@juj juj force-pushed the closure_via_emsdk branch from 6d5bad2 to 1f9afa9 Compare December 7, 2019 15:42
@juj
Copy link
Collaborator Author

juj commented Dec 7, 2019

@sbc100 I think I'll need your help wrangling the CI, not sure how it relates to emsdk nowadays?

@sbc100
Copy link
Collaborator

sbc100 commented Dec 7, 2019

I think we should add it to the package.json file a the top level.

I think we should have npm install run by emsdk as a post-install step. I'll take a look at that.

@juj
Copy link
Collaborator Author

juj commented Dec 8, 2019

Superceded by #9989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants