Migrate Closure to be shipped via emsdk or manually installed via npm.#9986
Closed
juj wants to merge 1 commit intoemscripten-core:incomingfrom
Closed
Migrate Closure to be shipped via emsdk or manually installed via npm.#9986juj wants to merge 1 commit intoemscripten-core:incomingfrom
juj wants to merge 1 commit intoemscripten-core:incomingfrom
Conversation
Closed
6d5bad2 to
1f9afa9
Compare
Collaborator
Author
|
@sbc100 I think I'll need your help wrangling the CI, not sure how it relates to emsdk nowadays? |
Collaborator
|
I think we should add it to the package.json file a the top level. I think we should have |
Collaborator
Author
|
Superceded by #9989. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes Closure from the tree, and migrates it to be installed by running one of:
Needs emscripten-core/emsdk#403 to land first.