[bazel] Add an :all target to binary repos#1295
Merged
kripken merged 1 commit intoemscripten-core:mainfrom Oct 30, 2023
attilaolah:issue-1294
Merged
[bazel] Add an :all target to binary repos#1295kripken merged 1 commit intoemscripten-core:mainfrom attilaolah:issue-1294
kripken merged 1 commit intoemscripten-core:mainfrom
attilaolah:issue-1294
Conversation
This is the simplest solution to my problem described in #1294. I'm happy to change this to something more specific, e.g. by exporting only the files I currently need, but it seems like having an :all target is the most future-proof way here.
walkingeyerobot
approved these changes
Oct 30, 2023
Member
|
Test error is not related and should not block this landing. @tlively the error is in recent Lattice code in Binaryen, In file included from /root/project/binaryen/main/src/tools/wasm-fuzz-lattices.cpp:21:0:
/usr/include/c++/7/variant: In instantiation of 'constexpr const size_t std::variant_size_v<wasm::RandomFullLattice::L>':
/usr/include/c++/7/variant:702:10: required from 'struct std::__detail::__variant::__gen_vtable<wasm::RandomFullLattice::ElementImpl, wasm::RandomFullLattice::getBottom() const::<lambda(const auto:5&)>&&, wasm::RandomFullLattice::L&>'
/usr/include/c++/7/variant:1255:23: required from 'constexpr decltype(auto) std::visit(_Visitor&&, _Variants&& ...) [with _Visitor = wasm::RandomFullLattice::getBottom() const::<lambda(const auto:5&)>; _Variants = {wasm::RandomFullLattice::L&}]'
/root/project/binaryen/main/src/tools/wasm-fuzz-lattices.cpp:666:29: required from here
/usr/include/c++/7/variant:97:29: error: incomplete type 'std::variant_size<wasm::RandomFullLattice::L>' used in nested name specifier
inline constexpr size_t variant_size_v = variant_size<_Variant>::value;
^~~~~~~~~~~~~~ |
mmorel-35
pushed a commit
to mmorel-35/emsdk
that referenced
this pull request
Feb 3, 2026
Having an :all target is the most future-proof way here. Closes emscripten-core#1294.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the simplest solution to my problem described in #1294.
I'm happy to change this to something more specific, e.g. by exporting only the files I currently need, but it seems like having an :all target is the most future-proof way here.
Closes #1294.