Skip to content

Add suggestion to install using --permanent or --system on windows. NFC#1308

Merged
sbc100 merged 1 commit intomainfrom
windows_hints
Dec 4, 2023
Merged

Add suggestion to install using --permanent or --system on windows. NFC#1308
sbc100 merged 1 commit intomainfrom
windows_hints

Conversation

@sbc100
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 commented Dec 2, 2023

Fixes: #1307

@sbc100 sbc100 changed the title Add suggestion to install using --permanent or --system on window… Add suggestion to install using --permanent or --system on windows. NFC Dec 2, 2023
@sbc100 sbc100 requested review from dschuff and kripken and removed request for dschuff December 2, 2023 16:28
Copy link
Copy Markdown
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some convenient way from here to remind the user how to find out what these flags mean? (either some help text along with this output, or a pointer to emscripten.org, or something like that?)

@sbc100
Copy link
Copy Markdown
Collaborator Author

sbc100 commented Dec 4, 2023

Is there some convenient way from here to remind the user how to find out what these flags mean? (either some help text along with this output, or a pointer to emscripten.org, or something like that?)

--help contains more information on the flag. Are you suggesting that we recommend --help here?

@dschuff
Copy link
Copy Markdown
Member

dschuff commented Dec 4, 2023

I dunno maybe not, I guess that would be a little redundant, if they could just rerun this same command with --help

@sbc100 sbc100 merged commit ef77dcc into main Dec 4, 2023
@sbc100 sbc100 deleted the windows_hints branch December 4, 2023 17:26
mmorel-35 pushed a commit to mmorel-35/emsdk that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several troubles with SDK installer on Windows

2 participants