Error on unknown arguments passed to emsdk activate#1313
Conversation
sbc100
force-pushed
the
error_on_bad_args
branch
from
e78ad5f to
d98d5c2
Compare
sbc100
changed the title
emsdk activate
|
ptal |
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
oh oops, I left a comment and didn't submit it...
| if tool is None: | ||
| error_on_missing_tool(arg) | ||
| if tool is None: | ||
| error_on_missing_tool(arg) |
There was a problem hiding this comment.
so this means that args of the form --arg will now go through this missing tool logic. Does it print a message that makes sense for non-tool args?
There was a problem hiding this comment.
Yes, you will not see no tool found: --arg rather than silently ignoring it
There was a problem hiding this comment.
Right sorry, I guess what I meant was, should the error message be generalized to something like "unknown argument or no tool found by that name", since the error could now be either one of those cases.
There was a problem hiding this comment.
other command like emsdk install already report error: tool or SDK not found: '--foo'.. we could perhaps make that nicer, but that seems separate (and less important?) to ignoring args.
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
makes sense, I don't want to block this PR, just wanted to bring it up.
2 participants
See #1312