Skip to content

[bazel] add tarball as an optional output#1383

Merged
walkingeyerobot merged 1 commit intoemscripten-core:mainfrom
walkingeyerobot:main
May 15, 2024
Merged

[bazel] add tarball as an optional output#1383
walkingeyerobot merged 1 commit intoemscripten-core:mainfrom
walkingeyerobot:main

Conversation

@walkingeyerobot
Copy link
Copy Markdown
Collaborator

@walkingeyerobot walkingeyerobot commented May 15, 2024

Usage would be something like:

filegroup(
    name = "hello-world-tarball",
    srcs = [":hello-world-wasm"],
    output_group = "_wasm_tar",
)

Fixes #1382

@walkingeyerobot
[bazel] add tarball as an optional output
fc713e2 
Usage would be something like:
```
filegroup(
    name = "hello-world-tarball",
    srcs = [":hello-world-wasm"],
    output_group = "_wasm_tar",
)
```
@walkingeyerobot walkingeyerobot mentioned this pull request May 15, 2024
Closed
sbc100
sbc100 approved these changes May 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp lgtm

@walkingeyerobot walkingeyerobot merged commit 399e539 into emscripten-core:main May 15, 2024
mmorel-35 pushed a commit to mmorel-35/emsdk that referenced this pull request Feb 3, 2026
@walkingeyerobot @mmorel-35
[bazel] add tarball as an optional output (emscripten-core#1383)
d47410e 
Usage would be something like:
```
filegroup(
    name = "hello-world-tarball",
    srcs = [":hello-world-wasm"],
    output_group = "_wasm_tar",
)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Version of wasm_cc_binary that doesn't untar the result?

2 participants

@walkingeyerobot @sbc100