Remove all vs-tool references#931
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Nov 14, 2021
Merged
Conversation
jmglogow
added a commit
to jmglogow/emsdk
that referenced
this pull request
Nov 14, 2021
Untested, but the original code looks wrong.
jmglogow
force-pushed
the
fix-vs-tool
branch
from
73fb642 to
49f5bc3
Compare
Collaborator
|
Actually I did a little digging it looks like vs-tool was removed back in #395. Can you just remove this line completely instead? |
Collaborator
|
(All references to vs-tools can be removed). |
They were originally removed from emsdk_manifest.json in commit 12f1824 ("Remove Tools and SDKs that do no longer work after migration from Mozilla to Google hosting. (emscripten-core#395)").
jmglogow
force-pushed
the
fix-vs-tool
branch
from
49f5bc3 to
878ffb2
Compare
sbc100
approved these changes
Nov 14, 2021
mmorel-35
pushed a commit
to mmorel-35/emsdk
that referenced
this pull request
Feb 3, 2026
) They were originally removed from emsdk_manifest.json in commit 12f1824 ("Remove Tools and SDKs that do no longer work after migration from Mozilla to Google hosting. (emscripten-core#395)").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested, but the original code looked wrong.