Add recipe for r-sweater#4305
Conversation
|
|
|
And another recipe for Welcome to dependency hell! 😂 |
Should the dependencies be resolved in their own pull request? Or can all the dependencies be bundled in this pull request? |
You can add them all in this pull request and |
|
Just a heads up, I just renamed the branches so |
|
Regarding the When do I need to patch the C/C++ library? |
I don't think you need to. The conda-forge recipe for Btw, could you rebase or merge the changes from main? That way I could check the build logs |
Done. Thanks for the help! |
|
@IsabelParedes The build is failing because it request the file instead of Note the different case. What is the correct way to handle this case? Thanks! |
e1d1a81 to
4d5fa4b
Compare
|
The CI for 7ff1aea reported another missing library ( The CI for aeaf6a1 reported some cross-compilation error. Any recommendation regarding how to patch the source code? |
|
The cross-compilation error was reported upstream s-u/fastmatch#13. Any reading documentation regarding how to create the patch file? Thanks! |
|
Here's a basic workflow for creating a patch (feel free to add it to the documentation 🙂):
wget https://cran.r-project.org/src/contrib/fastmatch_1.1-8.tar.gz
git init
git add .
git commit -m "First commit"
git add .
git commit -m "Fix the thing"
git format-patch d7c9948
|
|
Thanks for the guidance with the patch. I included the patch in f9b77e6 and we progressed to the next circle of dependency hell. 🍾 🤣 The build script fails with I didn't find The full build script output is |
|
Hi @rgaiacs ! When I test your PR locally, there are no errors when building You can move the |
|
I checked the build logs again. Everything looks good for Now you just need a recipe for |
Interesting. In my memory, I followed the steps in described in https://emscripten-forge.org/development/local_builds/ using Pixi. I will try to replicate it and document in a separate issue / pull request.
👍 I will continue my "The Divine Comedy" journey. |
|
Good morning! New week. New energy to navigate the dependency hell for this PR. I created a recipe for r-xml2 should be compatible with libxml2 2.15.1 that was already packaged, see https://github.com/emscripten-forge/recipes/blob/04d5cda6ae3b9a9bda4b8c44055f7e4e0f757847/recipes/recipes_emscripten/libxml2/recipe.yaml. @IsabelParedes any tip on how to investigate this further? Thanks! |
|
So the commit I just pushed is one way to fix it. The other way (and probably better way) is to update this line Line 476 in 66ceb12 So that when solving the environment it picks version 2.15 and not 2.13 and that would work for all other packages depending on Hope this helps! |
Thanks for the commit. I was not sure if add this type of constrains was OK or not. 1f9bd8b was with a problem regarding the Now, I'm surprise with the fact that pixi add r-base>=4.5 r-usethisoutputs @IsabelParedes do you have any suggestion? |
|
This is a bit of an embedded dependency which is hard to spot. Basically you need to add yet another recipe for I normally debug these issues by trying to create an environment with the problematic dependencies, in this case just
Perhaps when you're testing with |
|
Thanks @IsabelParedes for the explanation. I will incorporate I'm learning so much with this experience that I'm planning to write a blog post covering the lessons learn that I can adapt to the documentation. |
|
I got some time at the end of today to work on the patch for A new missing dependence for A added a recipe for @IsabelParedes do you have previous experience with |
|
So Emscripten does not have epoll.h (see emscripten-core/emscripten#18671). But it does have poll.h, not sure if this is a suitable replacement but maybe worth a try. Otherwise it might be necessary to disable the epoll functionality. |
Interesting. 😄 I saw that George Stagg wrote in a issue at webr that
@IsabelParedes is it acceptable to use r-wasm fork? |
For testing is okay. But for merging it would be better to convert the changes in that |
|
I looked a bit on how WebR builds the podman pull ghcr.io/r-wasm/webr:main
podman run -it ghcr.io/r-wasm/webr:main /bin/shI run in a R session install.packages("pak")
pak::pak("r-wasm/rwasm")
library(rwasm)
build("github::r-wasm/fs@webr")The cross compilation log was I noticed that the parameters used by the WebR team to cross-compile when the WebR team is using @IsabelParedes do you know how |
based on the work from r-wasm team.
Co-authored-by: Isabel Paredes <isabel.paredes@quantstack.net>
Add r-usethis to build requirment of r-quanteda will make rattler-build to first prepare r-usethis.
because it depends of r-rappdirs that is architecture dependent.
|
I new dependence is missing. 😢 |
Follow up from #4298 targeting
emscripten-4xbranch.The rule is failing due to
Help wanted. Thanks!