Skip to content

Comments

feat: add option to install all components at init#101

Merged
ryanhagerty merged 2 commits intodevelopfrom
cli-11-eject-install
Apr 25, 2022
Merged

feat: add option to install all components at init#101
ryanhagerty merged 2 commits intodevelopfrom
cli-11-eject-install

Conversation

@ryanhagerty
Copy link
Contributor

Summary

This PR fixes/implements the following:

  • Adds option to install all default system components at the start

How to review this PR

  • Pull this branch down, run npm build and npm link
  • Create a new Drupal project somewhere. I used composer create-project drupal/recommended-project drupal-folder
  • Go into that folder and run npm link @emulsify/cli (make sure there are no warnings/errors)
  • Run emulsify init "Theme Name". You'll see a new option listed that allows an individual to install all components instead of just the default (screen shot below)
  • Install all the components. emulsify system install compound --all. To verify, you can go to your theme directory and checkout the components. For example, the card is not a default component.

Screen Shot 2022-02-25 at 9 57 20 AM

Closing issues
Closes #11

@ryanhagerty ryanhagerty added the 👍 Ready for Review Work is ready for review. label Feb 25, 2022
Copy link
Collaborator

@patrickocoffeyo patrickocoffeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ryanhagerty! I left a couple of comments here, but overall this looks great!

@patrickocoffeyo
Copy link
Collaborator

One more quick note... do you think it'd make sense to document the new --all parameter in the usage md?

@amazingrando amazingrando added 👉 Needs Work Reviewer has requested changes. and removed 👍 Ready for Review Work is ready for review. labels Apr 7, 2022
@ryanhagerty ryanhagerty added 👍 Ready for Review Work is ready for review. and removed 👉 Needs Work Reviewer has requested changes. labels Apr 22, 2022
@ryanhagerty
Copy link
Contributor Author

@patrickocoffeyo Thanks for the review! Comments addressed.

Copy link
Collaborator

@patrickocoffeyo patrickocoffeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanhagerty LGTM, nice!! 🙌

@ryanhagerty ryanhagerty merged commit ff174d6 into develop Apr 25, 2022
@ryanhagerty ryanhagerty deleted the cli-11-eject-install branch April 25, 2022 11:52
@ModulesUnraveled ModulesUnraveled mentioned this pull request May 26, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👍 Ready for Review Work is ready for review. released

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Add an eject command that simply installs all components from the project's system.

3 participants