Skip to content

Comments

feat: adding consola for logging handling#31

Merged
patrickocoffeyo merged 2 commits intodevelopfrom
feat/consola
Oct 29, 2021
Merged

feat: adding consola for logging handling#31
patrickocoffeyo merged 2 commits intodevelopfrom
feat/consola

Conversation

@mikeethedude
Copy link
Contributor

@mikeethedude mikeethedude commented Oct 20, 2021

Summary

Adds Consola library for logging with usage in our log handler. This should allow for further improvements down the line.

How to review this PR

  • npm run build
  • npm link
  • Attempt to setup a new emulsify instance with emsulsify init <args> and observe logging output. Should look similar with Consola as we haven't changed colors or settings.
  • Make sure to fail to pass in platform or path to see those error messages.

Closing issues

Closes #28

@mikeethedude mikeethedude added the 👍 Ready for Review Work is ready for review. label Oct 20, 2021
@mikeethedude mikeethedude self-assigned this Oct 20, 2021
Copy link
Collaborator

@patrickocoffeyo patrickocoffeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! Awesome work!

@patrickocoffeyo patrickocoffeyo merged commit d3b9d79 into develop Oct 29, 2021
@patrickocoffeyo patrickocoffeyo deleted the feat/consola branch October 29, 2021 19:50
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👍 Ready for Review Work is ready for review. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace stand-in logging tools with consola

2 participants