Skip to content

Comments

Memoize the findFileInCurrentPath method with fileName being the key#33

Merged
patrickocoffeyo merged 11 commits intodevelopfrom
feat/memoize-findfileincurrentpath
Nov 5, 2021
Merged

Memoize the findFileInCurrentPath method with fileName being the key#33
patrickocoffeyo merged 11 commits intodevelopfrom
feat/memoize-findfileincurrentpath

Conversation

@callinmullaney
Copy link
Contributor

@callinmullaney callinmullaney commented Oct 29, 2021

Summary

  • Memoize the findFileInCurrentPath method with fileName being the key.

This PR addresses the following issue

Documentation Update (required)

  • None

Testing:

  • Run npm run test and verify it passes

@callinmullaney callinmullaney self-assigned this Oct 29, 2021
@callinmullaney callinmullaney changed the title Feat/memoize findfileincurrentpath Memoize the findFileInCurrentPath method with fileName being the key Oct 29, 2021
@callinmullaney
Copy link
Contributor Author


    src/util/fs/findFileInCurrentPath.ts:14:17 - error TS2345: Argument of type 'string' is not assignable to parameter of type '(fileName: string) => string'.

    14   R.memoizeWith(fileName, (fileName: string): string | void => {

@callinmullaney callinmullaney added the 👍 Ready for Review Work is ready for review. label Nov 3, 2021
@callinmullaney
Copy link
Contributor Author

@patrickocoffeyo Thank you again for mentoring on this one. Sending it your way for contrib credit.

Copy link
Collaborator

@patrickocoffeyo patrickocoffeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for putting this together 🙌

@patrickocoffeyo patrickocoffeyo merged commit dd7f32d into develop Nov 5, 2021
@patrickocoffeyo patrickocoffeyo deleted the feat/memoize-findfileincurrentpath branch November 5, 2021 20:10
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👍 Ready for Review Work is ready for review. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants