Skip to content

Comments

Feat/14#39

Merged
patrickocoffeyo merged 4 commits intodevelopfrom
feat/14
Nov 19, 2021
Merged

Feat/14#39
patrickocoffeyo merged 4 commits intodevelopfrom
feat/14

Conversation

@JeffTomlinson
Copy link
Collaborator

@JeffTomlinson JeffTomlinson commented Nov 16, 2021

Summary

This PR fixes/implements the following bugs/features

  • Adds system configuration validation during system install.

Explain the motivation for making this change. What existing problem does the pull request solve?

See issue: #14

How to review this PR

  • In a new project with a theme but without a system installed, make a change to the system.json or variant.json schema file that would cause the "compound" system config to fail validation. For example: add description to the required properties for definitions.components in the ./src/schemas/variant.json schema.
  • npm run build
  • In the emulsify theme run emulsify system install compound
  • You should see schema validation errors and a message that the system installation failed.
  • Revert the change you made to the schema and npm run build again
  • In the emulsify theme run emulsify system install compound
  • The compound system should install without errors

Closing issues

Closes #14

Copy link
Collaborator

@patrickocoffeyo patrickocoffeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@patrickocoffeyo patrickocoffeyo merged commit 311e754 into develop Nov 19, 2021
@patrickocoffeyo patrickocoffeyo deleted the feat/14 branch November 19, 2021 22:43
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration File Validation

2 participants