Skip to content

Comments

fix: exit-status#73

Merged
ModulesUnraveled merged 7 commits intodevelopfrom
fix/exit-status
Dec 22, 2021
Merged

fix: exit-status#73
ModulesUnraveled merged 7 commits intodevelopfrom
fix/exit-status

Conversation

@ModulesUnraveled
Copy link
Contributor

@ModulesUnraveled ModulesUnraveled commented Dec 21, 2021

Currently a successful system install reports an exit status of 1 (Error). A successful install should return 0 (Success).

I discovered this when trying to do an automated test in compound:
Screen Shot 2021-12-21 at 9 45 08 AM

@ModulesUnraveled ModulesUnraveled added the 👍 Ready for Review Work is ready for review. label Dec 21, 2021
@mikeethedude mikeethedude added the 🎉 Passes Code Review Code is approved by the reviewer. label Dec 21, 2021
@mikeethedude mikeethedude self-requested a review December 21, 2021 15:51
Copy link
Contributor

@mikeethedude mikeethedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. I get the success message when it should be successful and not when it isn't!

@mikeethedude mikeethedude added 🎉 Passes Functional Review Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Dec 22, 2021
@ModulesUnraveled ModulesUnraveled merged commit b67f92c into develop Dec 22, 2021
@ModulesUnraveled ModulesUnraveled deleted the fix/exit-status branch December 22, 2021 23:01
@github-actions
Copy link

🎉 This PR is included in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. released

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants