Skip to content

Comments

feat: improve drupal init success message#92

Merged
ModulesUnraveled merged 1 commit intodevelopfrom
cli-58-improve-init-success
Feb 22, 2022
Merged

feat: improve drupal init success message#92
ModulesUnraveled merged 1 commit intodevelopfrom
cli-58-improve-init-success

Conversation

@ryanhagerty
Copy link
Contributor

@ryanhagerty ryanhagerty commented Feb 11, 2022

Summary

This PR fixes/implements the following:

How to review this PR

  • Pull this branch down, run npm build and npm link
  • Create a new Drupal project somewhere. I used composer create-project drupal/recommended-project drupal-folder
  • Go into that folder and run npm link @emulsify/cli (make sure there are no warnings/errors)
  • Run emulsify init "Theme Name" and see the improved message like the screenshot below. See the code diff for the change.

Screen Shot 2022-02-11 at 9 59 41 AM

Closing issues
Closes #58

@ryanhagerty ryanhagerty added the 👍 Ready for Review Work is ready for review. label Feb 11, 2022
Copy link
Collaborator

@patrickocoffeyo patrickocoffeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@patrickocoffeyo patrickocoffeyo added the 🎉 Passes Code Review Code is approved by the reviewer. label Feb 18, 2022
Copy link
Contributor

@ModulesUnraveled ModulesUnraveled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@ModulesUnraveled ModulesUnraveled added 🎉 Passes Functional Review Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Feb 22, 2022
@ModulesUnraveled ModulesUnraveled merged commit 5de8e1f into develop Feb 22, 2022
@ModulesUnraveled ModulesUnraveled deleted the cli-58-improve-init-success branch February 22, 2022 12:10
@ModulesUnraveled ModulesUnraveled mentioned this pull request May 26, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. released

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Improve drupal init success message

3 participants