build: updating dependencies and linting#94
Merged
ModulesUnraveled merged 4 commits intodevelopfrom Feb 23, 2022
Merged
Conversation
patrickocoffeyo
approved these changes
Feb 23, 2022
Collaborator
|
LGTM, nothing functional is changing here 👍 |
Contributor
Author
|
@patrickocoffeyo oh shoot! I meant to ask about the new linting config. It removed some parentheses that I found helpful. I wanted your opinion on if we should override the new setting |
Collaborator
|
@ModulesUnraveled as in this diff here? I think it's fine either way, it's a matter of stylistic preference and does not alter the way the code functions. |
Contributor
Author
|
Yeah, that's what I was referring to. And I understand it's a stylistic preference, but it seemed clearer to me the polls way. Oh well... |
Collaborator
|
Yeah, so you can adjust that rule and add 'em back if you prefer, either way is totally fine 👍 |
Merged
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following:
How to review this PR
npm buildandnpm linknpm run testand verify no failing testnpm run lintand verify there are no linting issuescomposer create-project drupal/recommended-project drupal-foldernpm link @emulsify/cliemulsify init "Theme Name"and verify a theme is initialized