Skip to content

Comments

build: updating dependencies and linting#94

Merged
ModulesUnraveled merged 4 commits intodevelopfrom
chore/package-lock-update
Feb 23, 2022
Merged

build: updating dependencies and linting#94
ModulesUnraveled merged 4 commits intodevelopfrom
chore/package-lock-update

Conversation

@ModulesUnraveled
Copy link
Contributor

@ModulesUnraveled ModulesUnraveled commented Feb 22, 2022

Summary

This PR fixes/implements the following:

  • Updates dependencies to satisfy Dependabot tickets, etc.
  • Lints all the things

How to review this PR

  • Pull this branch down, run npm build and npm link
  • Run npm run test and verify no failing test
  • Run npm run lint and verify there are no linting issues
  • Create a new Drupal project somewhere. I used composer create-project drupal/recommended-project drupal-folder
  • Go into that folder and run npm link @emulsify/cli
  • Run emulsify init "Theme Name" and verify a theme is initialized

@ModulesUnraveled ModulesUnraveled marked this pull request as draft February 22, 2022 12:28
@ModulesUnraveled ModulesUnraveled marked this pull request as ready for review February 22, 2022 12:38
@ModulesUnraveled ModulesUnraveled changed the title chore: updating dependencies build: updating dependencies Feb 22, 2022
@ModulesUnraveled ModulesUnraveled changed the title build: updating dependencies build: updating dependencies and linting Feb 22, 2022
@patrickocoffeyo
Copy link
Collaborator

LGTM, nothing functional is changing here 👍

@patrickocoffeyo patrickocoffeyo added the 🎉 Passes Code Review Code is approved by the reviewer. label Feb 23, 2022
@ModulesUnraveled ModulesUnraveled merged commit cbee1b7 into develop Feb 23, 2022
@ModulesUnraveled ModulesUnraveled deleted the chore/package-lock-update branch February 23, 2022 15:27
@ModulesUnraveled
Copy link
Contributor Author

@patrickocoffeyo oh shoot! I meant to ask about the new linting config. It removed some parentheses that I found helpful. I wanted your opinion on if we should override the new setting

@patrickocoffeyo
Copy link
Collaborator

@ModulesUnraveled as in this diff here? I think it's fine either way, it's a matter of stylistic preference and does not alter the way the code functions.

@ModulesUnraveled
Copy link
Contributor Author

Yeah, that's what I was referring to. And I understand it's a stylistic preference, but it seemed clearer to me the polls way. Oh well...

@patrickocoffeyo
Copy link
Collaborator

Yeah, so you can adjust that rule and add 'em back if you prefer, either way is totally fine 👍

@ModulesUnraveled ModulesUnraveled mentioned this pull request May 26, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 Passes Code Review Code is approved by the reviewer. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants