Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

@alex-oleshkevich
Copy link
Contributor

Based on #102
Seems that the author of #102 did not notice a call for update, so I am creating a new PR in order to proceed with this backend.

@encode/maintainers please do a review

closes #102
closes #3

README.md Outdated

* Serialization / deserialization to support broadcasting structured data.
* Backends for Redis Streams, Apache Kafka, and RabbitMQ.
* Backends for Apache Kafka, and RabbitMQ.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor Author

@alex-oleshkevich alex-oleshkevich Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is What's next section. Redis Streams lands with this PR and Kafka is already there.

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Apr 22, 2024

Are you able to give a brief pointer towards when there'd be a use-case for redis streams vs. redis pub/sub?

(Just in this conversation is enough, I don't think we have sufficient docs to have a good place for this right now)

@alex-oleshkevich
Copy link
Contributor Author

Redis Streams is a lightweight Kafka alternative. While pub sub is fire-and-forget, Redis stream is an append only log.

@lovelydinosaur
Copy link
Contributor

Reviews README and discovers that past me already wrote about this. Thanks that person.

To be more capable we'd really want to [...]

Add support for subscribe('chatroom', history=100) for backends which provide persistence. (Redis Streams, Apache Kafka) This will allow applications to subscribe to channel updates, while also being given an initial window onto the most recent events. We might also want to support some basic paging operations, to allow applications to scan back in the event history.

Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@alex-oleshkevich alex-oleshkevich merged commit c4b4d59 into encode:master Apr 22, 2024
@tsotnesharvadze
Copy link
Contributor

thanks 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants