This repository was archived by the owner on Aug 19, 2025. It is now read-only.
add retuning 'int' with redis publish #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this is out of scope of this library. Other backend may not support returning this value or may return something different. We want to keep API same for all backends. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is logic that I want to determine if it is subscribed and process it.
For example, if I don't have any subscribers, I want to discard or retry the publish.
I didn't know if a publish other than redis would return an int, so I made it the
Optional[int]type in the Broadcast class and theinttype in the RedisBackend class.If all the subscribers are disconnected, I want the publish return to be 0, so I'd like to merge this pull request as well.