Skip to content

Fix AttributeError when importing on Python 3.14 #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 2 commits into from
Apr 11, 2025
Merged

Fix AttributeError when importing on Python 3.14 #1005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c399a9
Fix AttributeError when importing on Python 3.14
hugovk Apr 11, 2025
658bcec
Comment the SOCKET_OPTION exclusion
hugovk Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion httpcore/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,6 @@ def __init__(self, *args, **kwargs): # type: ignore

__locals = locals()
for __name in __all__:
if not __name.startswith("__"):
# Exclude SOCKET_OPTION, it causes AttributeError on Python 3.14
if not __name.startswith(("__", "SOCKET_OPTION")):
setattr(__locals[__name], "__module__", "httpcore") # noqa