Default ssl contexts per http versions.#3340
Closed
T-256 wants to merge 1 commit intoencode:version-1.0from
Closed
Default ssl contexts per http versions.#3340T-256 wants to merge 1 commit intoencode:version-1.0from
T-256 wants to merge 1 commit intoencode:version-1.0from
Conversation
T-256
commented
Oct 9, 2024
httpx/_config.py
Outdated
Comment on lines
+133
to
+135
| def from_defaults( | ||
| cls, http1: bool = True, http2: bool = False | ||
| ) -> "SSLContext": |
Contributor
Author
There was a problem hiding this comment.
should it be thread safe?
Comment on lines
+142
to
+145
| alpn_idents = [] | ||
| if http1: | ||
| alpn_idents.append("http/1.1") | ||
| if http2: | ||
| alpn_idents.append("h2") | ||
| context.set_alpn_protocols(alpn_idents) |
Contributor
Author
There was a problem hiding this comment.
previously, it was only using http2, was there any reason?
if ssl.HAS_ALPN:
alpn_idents = ["http/1.1", "h2"] if http2 else ["http/1.1"]
context.set_alpn_protocols(alpn_idents)
Contributor
|
Heya. Gonna suggest we have a design discussion before considering this an issue.. |
Contributor
Author
|
Done, #3341 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref: #3022 (review)
Instead of creating ssl context per client, we now re-use available default contexts for different http versions configurations.
TODO