Skip to content

Reorganize timeout config tests #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florimondmanca merged 1 commit into from
Oct 22, 2019
Merged

Reorganize timeout config tests #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 31 additions & 14 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,6 @@ def test_empty_http_version():
httpx.HTTPVersionConfig([])


def test_timeout_repr():
timeout = httpx.TimeoutConfig(timeout=5.0)
assert repr(timeout) == "TimeoutConfig(timeout=5.0)"

timeout = httpx.TimeoutConfig(read_timeout=5.0)
assert (
repr(timeout)
== "TimeoutConfig(connect_timeout=None, read_timeout=5.0, write_timeout=None)"
)


def test_limits_repr():
limits = httpx.PoolLimits(hard_limit=100)
assert (
Expand All @@ -181,14 +170,31 @@ def test_ssl_eq():
assert ssl == httpx.SSLConfig(verify=False)


def test_limits_eq():
limits = httpx.PoolLimits(hard_limit=100)
assert limits == httpx.PoolLimits(hard_limit=100)


def test_timeout_eq():
timeout = httpx.TimeoutConfig(timeout=5.0)
assert timeout == httpx.TimeoutConfig(timeout=5.0)


def test_limits_eq():
limits = httpx.PoolLimits(hard_limit=100)
assert limits == httpx.PoolLimits(hard_limit=100)
def test_timeout_from_nothing():
timeout = httpx.TimeoutConfig()
assert timeout.connect_timeout is None
assert timeout.read_timeout is None
assert timeout.write_timeout is None


def test_timeout_from_none():
timeout = httpx.TimeoutConfig(timeout=None)
assert timeout == httpx.TimeoutConfig()


def test_timeout_from_one_none_value():
timeout = httpx.TimeoutConfig(read_timeout=None)
assert timeout == httpx.TimeoutConfig()


def test_timeout_from_tuple():
Expand All @@ -201,6 +207,17 @@ def test_timeout_from_config_instance():
assert httpx.TimeoutConfig(timeout) == httpx.TimeoutConfig(timeout=5.0)


def test_timeout_repr():
timeout = httpx.TimeoutConfig(timeout=5.0)
assert repr(timeout) == "TimeoutConfig(timeout=5.0)"

timeout = httpx.TimeoutConfig(read_timeout=5.0)
assert (
repr(timeout)
== "TimeoutConfig(connect_timeout=None, read_timeout=5.0, write_timeout=None)"
)


@pytest.mark.skipif(
not hasattr(ssl.SSLContext, "keylog_filename"),
reason="requires OpenSSL 1.1.1 or higher",
Expand Down