Remove firebase dependency #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into remove-firebase-depend
banstack
approved these changes
Feb 16, 2022
Member
banstack
left a comment
banstack
left a comment
There was a problem hiding this comment.
lgtm
I have left a simple comment about HTML styling, however, it is such a microscopic detail and it doesn't break the page, This could be great beginner issue for a new member in the future
| target="_blank ">https://policies.google.com/<wbr>privacy?hl=en</a> | ||
| </u> | ||
| </ul> | ||
| </li> |
Member
There was a problem hiding this comment.
The </ul> and </li> should be swapped here, a very small quirk.
Because the opening <li> tag in line 294 is closed by the </li> on line 302 which should be before the closing </ul> tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been awhile since we've used firebase, time to remove it from our dependency list