Skip to content

Conversation

@rowanG077
Copy link
Contributor

…e slave if it can be deselected."

This reverts commit 91f56aa.

I was updating litex in my project and the udpraw core stopped working while still responding to pings. After bisecting I found that this is the offending commit.

I'm not sure whether the udpraw core code is wrong or this is wrong... For now I have reverted this locally. If this is not the correct way forward please let me know as well.

…e slave if it can be deselected."

This reverts commit 91f56aa.
@rowanG077
Copy link
Contributor Author

rowanG077 commented Jul 24, 2023

Looking a bit deeper. The reason it goes wrong is that in the udpraw core I don't use sink_dst_port as a filter. I assume I receive all packets and then set the sink_dst_port only when I have an outgoing packet. It's kind of silly to use a signal which is technically only valid when transmitting a packet as the selector on the crossbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant