Cut 1.0.0 release

[sds]

@enkessler If it's useful, here's a PR for cutting a release. I changed the format of the change log to use the present tense imperative style—if this is not appropriate feel free to change! (it tends to result in fewer words/characters)

• #134: Add support for non-ASCII characters on Windows
• #132: Install ffi gem requirement on Windows only
• #128: Convert environment variable values to strings when posix_spawn enabled
• #141: Support JRuby on Java >= 9

[coveralls]

Coverage remained the same at 94.688% when pulling 7673d0f on cut-0.10.0 into 27f9f60 on master.

[coveralls]

Coverage remained the same at 94.688% when pulling 5f5dac9 on cut-0.10.0 into 27f9f60 on master.

[coveralls]

Coverage remained the same at 94.688% when pulling 5f5dac9 on cut-0.10.0 into 27f9f60 on master.

[coveralls]

Coverage remained the same at 94.688% when pulling 5f5dac9 on cut-0.10.0 into 27f9f60 on master.

[coveralls]

Coverage remained the same at 94.688% when pulling 5f5dac9 on cut-0.10.0 into 27f9f60 on master.

[enkessler]

@sds , I have (finally) reviewed all of the changes that you have been doing recently. Good work! My only significant complaint is that the work was done directly on the master branch instead of the dev branch and then merged in. It's nice to have the master branch be 'ready to go' at any given time in case people want to grab the repo and tweak it for internal use or if we (for some unfathomable reason) would have to cut a new release without changes.

Additionally, due to the commit that you pulled in from #132, I think that it might be better to play it safe rather than sorry and make this a major version bump. This gem really should have stopped being a 0.x gem a long time ago and the new life being breathed into it after the long hibernation is as good a time as any to start with a nice new number. So how about we go with 1.0?

[sds]

Thanks for looking over the changes, @enkessler!

Apologies for developing on the master branch directly—I should have read the README more closely. Will do this in the future.

I've updated the PR to use version 1.0.0. Agree with your sentiments—given the length of time this gem has been in the wild, it seems reasonable to release these sets of updates as a 1.0.

[enkessler]

Looks good!

[sds]

Thanks for the review, @enkessler. I'm happy to merge, but just want to confirm if you were able to publish the gem as well?

[enkessler]

Not until it's all merged into master, no. If the master branch is what people are supposed to grab then the master branch is what should be used to build the gem, yes?

[sds]

My question is more "If I merge this, will you publish the gem"? Otherwise I wouldn't have merged, as to your point, master should reflect what is to be published. Perhaps I'm being overly cautious since I don't know how you prefer to run things, so sorry for the back/forth.

[enkessler]

No worries.

Ye Olde Release Checklist:

• make sure that the build is green
• make sure that the changelog is updated
• make sure that the version is bumped appropriately (i.e. Semantic versioning)
• build the gem from the green master commit
  • push the built gem to RubyGems
  • tag the commit in Git with a version tag

Once the merge build on master goes green, I can do the rest.

[enkessler]

@sds So, I see that the CI builds are green and I am able to build the gem from the gemspec, but I am not able to install and use the created gem. Are you able to build and use the gem from the latest master commit?

[enkessler]

And I am able to checkout the repo at v0.9.0 and build and install the gem successfully. So...yeah. I'm thinking to call this one a 'release candidate' rather than a full on release until I know that it is usable.

[sds]

@enkessler Can you share your output?

I'm able to build and install on macOS, but perhaps there's an issue with other operating systems.

⨠ gem build childprocess.gemspec
  Successfully built RubyGem
  Name: childprocess
  Version: 1.0.0
  File: childprocess-1.0.0.gem
⨠ gem install childprocess-1.0.0.gem
Building native extensions. This could take a while...
Successfully installed childprocess-1.0.0
1 gem installed

[enkessler]

I'm on Windows.

$ gem install childprocess-1.0.0.gem
ERROR:  Error installing childprocess-1.0.0.gem:
        ERROR: Failed to build gem native extension.

    current directory: C:/devl/Ruby/Ruby25-x64/lib/ruby/gems/2.5.0/gems/childprocess-1.0.0/ext
C:/devl/Ruby/Ruby25-x64/bin/ruby.exe mkrf_conf.rb

rake failed, exit code 1

Gem files will remain installed in C:/devl/Ruby/Ruby25-x64/lib/ruby/gems/2.5.0/gems/childprocess-1.0.0 for inspection.
Results logged to C:/devl/Ruby/Ruby25-x64/lib/ruby/gems/2.5.0/extensions/x64-mingw32/2.5.0/childprocess-1.0.0/gem_make.out
Temporarily enhancing PATH for MSYS/MINGW...
Building native extensions. This could take a while...

I'll try it on a Linux machine in a little bit.

[enkessler]

I can install it on Linux (Ubuntu). So it's a Windows thing.

[sds]

Ok, I'll look into this but will take some time. Haven't booted up a Ruby dev environment on Windows in a bit. It's likely related to #132 but can't confirm until I get access to my other machine.

[enkessler]

Ruby setup in Windows is pretty easy these days. I just started on a new project at work this morning and it's on a Windows machine. I had Ruby, Git, and RubyMine all set up inside of 20 minutes.

https://rubyinstaller.org/downloads/
https://git-scm.com/download/win

[sds]

Was able to reproduce. Fixed on master in f006e08.
Builds are green for Travis and AppVeyor.

[enkessler]

Ah, right. Because we weren't in a gemfile anymore but were instead in raw Ruby land. The fix makes sense.

It is now building and installing fine for me on Windows. I'll push up the new version to RubyGems when I get home. Thanks again!

[enkessler]

@sds It's in the wild!