Fix/show active network in tabs#609
Conversation
WalkthroughThis pull request includes updates to three Vue components. In the network management component, the logic for updating network order has been simplified by removing conditional checks, and the display logic now ensures that networks are added to "Pinned" or "New" lists when absent. The onboarding component has style changes that enable vertical scrolling on the body and enforce a minimum height for the onboarding container. Additionally, a modification to the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant C as App.vue Component
participant N as Networks Array
U->>C: Initiate network order update
C->>N: Call updateNetworkOrder() to assign new order
Note over C: displayNetworks computed property evaluates
C->>C: Check if network exists in Pinned/New lists
C->>N: Add network to list if absent
U->>C: View updated network display
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
💼 Build Files |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/extension/src/ui/action/App.vue(3 hunks)packages/extension/src/ui/onboard/App.vue(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: buildAll
- GitHub Check: test
🔇 Additional comments (4)
packages/extension/src/ui/onboard/App.vue (1)
108-108: LGTM! Good addition of min-height.Setting a minimum height ensures consistent layout regardless of content size.
packages/extension/src/ui/action/App.vue (3)
351-355: LGTM! Clean and focused implementation.The function correctly updates network order only when search input is empty, preventing unintended order changes during search.
633-640: LGTM! Smart handling of pinned networks.The implementation ensures the current network is always visible in the pinned category, improving user experience by maintaining context.
641-648: LGTM! Consistent handling of new networks.The implementation mirrors the pinned networks logic, ensuring the current network is always visible in the new networks category.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/extension/src/ui/action/utils/browser.ts (1)
65-79: Consider adding cache control togetLatestEnkryptUpdatesfor consistency.For consistency with
getLatestEnkryptVersion, consider adding the same cache control to this function.return fetch( - fetchUrl + fetchUrl, + { cache: "no-store" } )
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/extension/src/ui/action/utils/browser.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: buildAll
- GitHub Check: test
🔇 Additional comments (1)
packages/extension/src/ui/action/utils/browser.ts (1)
50-63: LGTM! Good addition of cache control.The addition of
{ cache: "no-store" }ensures that version checks always fetch fresh data, preventing stale cache from hiding available updates.
4 participants
Summary by CodeRabbit
New Features
Style
Chores