Conversation
[FIX] Asset Balances Not Showing for Rootstock
WalkthroughThis change enhances the asset information handler for Ethereum by introducing a new property ( Changes
Sequence Diagram(s)sequenceDiagram
participant T as getTokens
participant C as SupportedNetworks Config
participant B as getBlockscoutBalances
T->>C: Check network configuration for bsEndpoint
alt bsEndpoint is true
T->>B: Call getBlockscoutBalances for token balance retrieval
else bsEndpoint is false or missing
T->>T: Use alternative balance retrieval method
end
Possibly related PRs
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
💼 Build Files |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/extension/src/providers/ethereum/libs/assets-handlers/assetinfo-mew.ts (1)
200-202: Add error handling for networks withbsEndpointbut missingtbName.While the Blockscout integration looks good, consider adding error handling for networks that have
bsEndpointbut are missing thetbNameproperty. This could prevent potential issues if a network is misconfigured.} else if (supportedNetworks[chain].bsEndpoint) { + if (!supportedNetworks[chain].tbName) { + return Promise.reject( + `TOKENBALANCE-MEW: Network ${chain} is missing tbName configuration`, + ); + } return getBlockscoutBalances(chain, address); }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/extension/src/providers/ethereum/libs/assets-handlers/assetinfo-mew.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: buildAll
🔇 Additional comments (1)
packages/extension/src/providers/ethereum/libs/assets-handlers/assetinfo-mew.ts (1)
72-76: LGTM! Consistent addition ofbsEndpointproperty.The
bsEndpointproperty is consistently added to Rootstock, SyscoinNEVM, and Rollux networks, enabling them to use Blockscout for token balance retrieval.Also applies to: 125-128, 129-132
|
seems like token balances are fixed |
Summary by CodeRabbit