Feat/collapse networks menu#643
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request primarily updates various network configuration files by replacing icon asset imports from legacy formats (SVG/PNG) with the WebP format. No business or logic changes are introduced through these updates. In addition, the app’s UI code is refactored to simplify component structure and interactions—including menu layout adjustments and integration of Pinia for state management—without affecting core functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant M as app-menu Component
participant A as App.vue
participant PU as Pinia Store
U->>M: Clicks menu action (e.g., show updates)
M-->>A: Emits event (e.g., "show:updates-dialog")
A->>PU: Update state for modal visibility
A->>M: Re-render menu with updated state
U->>A: Closes modal (via "close:popup" event)
A->>PU: Update state (modal hidden)
Possibly related PRs
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (20)
packages/extension/src/providers/ethereum/networks/sepolia.ts (1)
7-23: Inconsistent Variable Naming
The network configuration is for Sepolia (as seen inname_longand homePage), yet the option and instance variables are namedgoerliOptionsandgoerli. For clarity and consistency, consider renaming these tosepoliaOptionsandsepolia.packages/extension/src/providers/ethereum/networks/vic.ts (1)
8-24: Branding and Naming Inconsistency
The network options object is namedtomoOptionsand usesNetworkNames.TomoChainandcoingeckoID: 'tomochain', yetname_longis set to "Viction" and the homePage points toviction.xyz. Please verify the intended branding: if the network is meant to be Viction, update both the enum and variable names to reflect this; if it is TomoChain, adjust the display names accordingly.packages/extension/src/providers/ethereum/networks/matic.ts (1)
1-1: Icon Import Updated to WebP
The icon asset is now imported from a.webpfile rather than a.svgfile. Please verify that the referenced file exists and is optimized for display, especially in the collapsed networks menu context.packages/extension/src/providers/ethereum/networks/fraxtal.ts (1)
1-1: Updated Icon Format to WebP
The import for the network icon has been updated from an SVG to a WEBP file. Ensure that the new image maintains the desired quality and dimensions for a consistent UI experience across network icons.packages/extension/src/providers/ethereum/networks/ftm.ts (1)
1-1: Transition to WebP Icon Format
The icon is now imported from a.webpfile. This aligns with the broader asset update across the project. Please confirm that the new icon remains compatible with all targeted browsers.packages/extension/src/providers/ethereum/networks/zkgoerli.ts (1)
1-1: Switch to WebP Icon Asset
The icon import has been modified to use a.webpfile instead of.svg. Verify that this new asset delivers sufficient resolution and clarity across different devices and display settings.packages/extension/src/providers/ethereum/networks/palm.ts (1)
1-1: WebP Icon Import Applied
The network icon is now sourced from a.webpfile, supporting the project's move to more efficient image formats. Please ensure that the icon meets UI standards in the collapsed interface and consider fallback solutions for any legacy browser compatibility issues.packages/extension/src/providers/polkadot/networks/pendulum/pendulum.ts (1)
9-9: Updated Icon Import for Pendulum Network
The icon import has been updated to use a WebP file (pendulum.webp) instead of the previous SVG. This change is purely cosmetic and ensures consistency across network assets. Please verify that the WebP asset exists in the expected directory (../icons/) and renders correctly in your UI.packages/extension/src/providers/polkadot/networks/bifrost/kusama.ts (1)
11-11: Updated Icon Import for Bifrost Kusama Network
The icon for the Bifrost Kusama network has been updated from an SVG to a WebP file. This standardization should help optimize asset performance and consistency. Please confirm that the WebP asset is located at the correct path (../icons/bifrost.webp) and that there are no unexpected side effects in the UI.packages/extension/src/providers/polkadot/networks/kusama.ts (1)
9-9: Updated Icon Import for Kusama Network
The icon import for the Kusama network now uses a WebP image (kusama.webp). This is in line with the overall asset format update. Ensure that the new asset is optimized and accessible, and consider if any fallback logic is needed for environments with limited WebP support.packages/extension/src/providers/polkadot/networks/assethub/assethub-ksm.ts (1)
12-12: Updated Icon Import for Asset Hub KSM
The asset icon has been updated from a PNG to a WebP file (assethub.webp). This change improves consistency across network configurations. Please verify that this WebP asset is available and renders properly in the application.packages/extension/src/providers/kadena/networks/kadena.ts (1)
6-6: Updated Icon Import for Kadena Network
The Kadena network now imports its icon from a WebP file (kadena-kda-logo.webp) instead of a SVG. This update aligns with the broader initiative to standardize icon formats across the project. Verify that the asset is present and consider potential fallback mechanisms for browsers that might not support WebP.packages/extension/src/providers/polkadot/networks/astar/assets/astar-assets.ts (1)
3-3: Standardize Icon Format for DOT Assets
The update to import the Polkadot icon as a WEBP file instead of the previous format is consistent with the project’s asset standardization. Please verify that the new WEBP asset exists at the specified path and renders correctly in the UI.packages/extension/src/providers/polkadot/networks/astar/astar.ts (1)
11-11: Update Astar Network Icon Format
The icon import on line 11 has been updated to use a WEBP file rather than PNG. This change aligns with the broader effort to optimize and standardize image assets. Ensure that the new WEBP file is optimized for all target browsers and that there are no regressions in how the icon is displayed.packages/extension/src/providers/ethereum/networks/skale/europa.ts (1)
13-13: Switch Icon to WEBP Format in Skale Options
The change on line 13 from a SVG file reference to a WEBP file (i.e.,'skaleEuropa.webp') is noted. This update helps maintain consistency across network configurations. Confirm that this asset update does not impact icon resolution or compatibility in various environments.packages/extension/src/providers/polkadot/networks/acala/assets/acala-assets.ts (1)
3-3: Update DOT Icon for Acala Assets
Changing the DOT icon import to use a WEBP file (line 3) aligns with the overall asset update strategy. Please ensure that the new WEBP file meets design expectations and is correctly referenced throughout the UI.packages/extension/src/providers/polkadot/networks/acala/karura.ts (1)
12-12: Convert Karura Icon to WEBP Format
The revised import on line 12, which now references../icons/karura.webp, successfully updates the icon to the WEBP format. Verify that this change is consistent with the visual design and that the WEBP file performs as expected on all supported platforms.packages/extension/src/ui/action/App.vue (3)
158-159: Typo in comment.
"Exapnded" should be spelled "Expanded."- * Exapnded Menu + * Expanded Menu
465-467: Fixed width might limit responsiveness.
Consider using a content-responsive approach if you plan to support multiple viewports or future UI expansions.
468-471: Ensure consistent design for expanded width.
800px works locally but might benefit from a fluid layout if the extension UI evolves.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (88)
packages/extension/src/providers/bitcoin/networks/icons/btc.svgis excluded by!**/*.svgpackages/extension/src/providers/bitcoin/networks/icons/doge.svgis excluded by!**/*.svgpackages/extension/src/providers/bitcoin/networks/icons/ltc.svgis excluded by!**/*.svgpackages/extension/src/providers/bitcoin/networks/icons/tbtc.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/5ire.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/aa.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/apex.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/arbitrum-nova.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/arbitrum.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/astr.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/aurora.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/avax.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/base.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/bitrock.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/bsc.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/caga.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/canto.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/celo.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/coti.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/degen.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/edgeware.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/etc.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/eth.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/form.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/forma.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/fraxtal.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/ftm.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/gno.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/godwoken.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/ham.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/immutable-zkevm.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/karura-evm.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/klaytn.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/linea.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/manta-pacific.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/matic.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/mode.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/moonbeam.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/moonriver.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/okc.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/ont-evm.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/op.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/opbnb.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/palm.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/rari.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/rootstock.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/sanko.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/scroll.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/sdn.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/shiba-inu.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/skaleBlockBrawlers.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skaleCalypsoNFTHub.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skaleCryptoBlades.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skaleCryptoColloseum.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skaleEuropa.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/skaleExorde.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skaleNebula.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skaleRazor.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skaleTitan.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skl-fuel.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/skl.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/sys_nevm.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/sys_rollux.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/telos.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/tsys_nevm.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/tsys_rollux.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/viction.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/xlayer.pngis excluded by!**/*.pngpackages/extension/src/providers/ethereum/networks/icons/zcd.svgis excluded by!**/*.svgpackages/extension/src/providers/ethereum/networks/icons/zksync.svgis excluded by!**/*.svgpackages/extension/src/providers/kadena/networks/icons/kadena-kda-logo.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/acala.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/amplitude.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/assethub.pngis excluded by!**/*.pngpackages/extension/src/providers/polkadot/networks/icons/astar.pngis excluded by!**/*.pngpackages/extension/src/providers/polkadot/networks/icons/bifrost.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/edgeware.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/karura.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/kusama.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/opal.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/pendulum.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/polkadot.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/quartz.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/shiden.pngis excluded by!**/*.pngpackages/extension/src/providers/polkadot/networks/icons/unique.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/vara.svgis excluded by!**/*.svgpackages/extension/src/providers/polkadot/networks/icons/westend.svgis excluded by!**/*.svgpackages/extension/src/providers/solana/networks/icons/sol.svgis excluded by!**/*.svg
📒 Files selected for processing (107)
packages/extension/src/providers/bitcoin/networks/bitcoin-testnet.ts(1 hunks)packages/extension/src/providers/bitcoin/networks/bitcoin.ts(1 hunks)packages/extension/src/providers/bitcoin/networks/dogecoin.ts(1 hunks)packages/extension/src/providers/bitcoin/networks/litecoin.ts(1 hunks)packages/extension/src/providers/ethereum/networks/5ire.ts(1 hunks)packages/extension/src/providers/ethereum/networks/aa.ts(1 hunks)packages/extension/src/providers/ethereum/networks/aat.ts(1 hunks)packages/extension/src/providers/ethereum/networks/arb-nova.ts(1 hunks)packages/extension/src/providers/ethereum/networks/arb.ts(1 hunks)packages/extension/src/providers/ethereum/networks/astr.ts(1 hunks)packages/extension/src/providers/ethereum/networks/aurora.ts(1 hunks)packages/extension/src/providers/ethereum/networks/avax.ts(1 hunks)packages/extension/src/providers/ethereum/networks/base.ts(1 hunks)packages/extension/src/providers/ethereum/networks/bitrock.ts(1 hunks)packages/extension/src/providers/ethereum/networks/bsc.ts(1 hunks)packages/extension/src/providers/ethereum/networks/cagaAnkara.ts(1 hunks)packages/extension/src/providers/ethereum/networks/canto.ts(1 hunks)packages/extension/src/providers/ethereum/networks/celo.ts(1 hunks)packages/extension/src/providers/ethereum/networks/coti-devnet.ts(1 hunks)packages/extension/src/providers/ethereum/networks/degen.ts(1 hunks)packages/extension/src/providers/ethereum/networks/dmt.ts(1 hunks)packages/extension/src/providers/ethereum/networks/edg.ts(1 hunks)packages/extension/src/providers/ethereum/networks/etc.ts(1 hunks)packages/extension/src/providers/ethereum/networks/eth.ts(1 hunks)packages/extension/src/providers/ethereum/networks/form-testnet.ts(1 hunks)packages/extension/src/providers/ethereum/networks/form.ts(1 hunks)packages/extension/src/providers/ethereum/networks/forma.ts(1 hunks)packages/extension/src/providers/ethereum/networks/fraxtal.ts(1 hunks)packages/extension/src/providers/ethereum/networks/ftm.ts(1 hunks)packages/extension/src/providers/ethereum/networks/glmr.ts(1 hunks)packages/extension/src/providers/ethereum/networks/gno.ts(1 hunks)packages/extension/src/providers/ethereum/networks/godwoken.ts(1 hunks)packages/extension/src/providers/ethereum/networks/ham.ts(1 hunks)packages/extension/src/providers/ethereum/networks/holesky.ts(1 hunks)packages/extension/src/providers/ethereum/networks/immutable-zkevm.ts(1 hunks)packages/extension/src/providers/ethereum/networks/karura.ts(1 hunks)packages/extension/src/providers/ethereum/networks/klay.ts(1 hunks)packages/extension/src/providers/ethereum/networks/linea.ts(1 hunks)packages/extension/src/providers/ethereum/networks/manta-pacific.ts(1 hunks)packages/extension/src/providers/ethereum/networks/matic.ts(1 hunks)packages/extension/src/providers/ethereum/networks/maticzk.ts(1 hunks)packages/extension/src/providers/ethereum/networks/mode.ts(1 hunks)packages/extension/src/providers/ethereum/networks/movr.ts(1 hunks)packages/extension/src/providers/ethereum/networks/okc.ts(1 hunks)packages/extension/src/providers/ethereum/networks/ontevm.ts(1 hunks)packages/extension/src/providers/ethereum/networks/op-bnb.ts(1 hunks)packages/extension/src/providers/ethereum/networks/op.ts(1 hunks)packages/extension/src/providers/ethereum/networks/palm.ts(1 hunks)packages/extension/src/providers/ethereum/networks/pop-apex.ts(1 hunks)packages/extension/src/providers/ethereum/networks/puppy.ts(1 hunks)packages/extension/src/providers/ethereum/networks/rari.ts(1 hunks)packages/extension/src/providers/ethereum/networks/rsk-testnet.ts(1 hunks)packages/extension/src/providers/ethereum/networks/rsk.ts(1 hunks)packages/extension/src/providers/ethereum/networks/scroll.ts(1 hunks)packages/extension/src/providers/ethereum/networks/sdn.ts(1 hunks)packages/extension/src/providers/ethereum/networks/sepolia.ts(1 hunks)packages/extension/src/providers/ethereum/networks/shib.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/README.md(2 hunks)packages/extension/src/providers/ethereum/networks/skale/blockBrawlers.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/calypso.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/cryptoBlades.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/cryptoColosseum.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/europa.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/exorde.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/nebula.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/razor.ts(1 hunks)packages/extension/src/providers/ethereum/networks/skale/skale-base.ts(4 hunks)packages/extension/src/providers/ethereum/networks/skale/titan.ts(1 hunks)packages/extension/src/providers/ethereum/networks/syscoin/nevm-testnet.ts(1 hunks)packages/extension/src/providers/ethereum/networks/syscoin/nevm.ts(1 hunks)packages/extension/src/providers/ethereum/networks/syscoin/rollux-testnet.ts(1 hunks)packages/extension/src/providers/ethereum/networks/syscoin/rollux.ts(1 hunks)packages/extension/src/providers/ethereum/networks/tlos.ts(1 hunks)packages/extension/src/providers/ethereum/networks/vic.ts(1 hunks)packages/extension/src/providers/ethereum/networks/xlayer.ts(1 hunks)packages/extension/src/providers/ethereum/networks/zcd.ts(1 hunks)packages/extension/src/providers/ethereum/networks/zkgoerli.ts(1 hunks)packages/extension/src/providers/ethereum/networks/zksync.ts(1 hunks)packages/extension/src/providers/ethereum/types/custom-evm-network.ts(1 hunks)packages/extension/src/providers/ethereum/ui/wallet-add-ethereum-network.vue(1 hunks)packages/extension/src/providers/kadena/networks/kadena-testnet.ts(1 hunks)packages/extension/src/providers/kadena/networks/kadena.ts(1 hunks)packages/extension/src/providers/polkadot/networks/acala/acala.ts(1 hunks)packages/extension/src/providers/polkadot/networks/acala/assets/acala-assets.ts(1 hunks)packages/extension/src/providers/polkadot/networks/acala/assets/karura-assets.ts(1 hunks)packages/extension/src/providers/polkadot/networks/acala/karura.ts(1 hunks)packages/extension/src/providers/polkadot/networks/assethub/assethub-dot.ts(1 hunks)packages/extension/src/providers/polkadot/networks/assethub/assethub-ksm.ts(1 hunks)packages/extension/src/providers/polkadot/networks/astar/assets/astar-assets.ts(1 hunks)packages/extension/src/providers/polkadot/networks/astar/astar.ts(1 hunks)packages/extension/src/providers/polkadot/networks/astar/shiden.ts(1 hunks)packages/extension/src/providers/polkadot/networks/bifrost/assets/bifrost-assets.ts(1 hunks)packages/extension/src/providers/polkadot/networks/bifrost/kusama.ts(1 hunks)packages/extension/src/providers/polkadot/networks/bifrost/polkadot.ts(1 hunks)packages/extension/src/providers/polkadot/networks/edgeware.ts(1 hunks)packages/extension/src/providers/polkadot/networks/kusama.ts(1 hunks)packages/extension/src/providers/polkadot/networks/pendulum/amplitude.ts(1 hunks)packages/extension/src/providers/polkadot/networks/pendulum/assets/pendulum-assets.ts(1 hunks)packages/extension/src/providers/polkadot/networks/pendulum/pendulum.ts(1 hunks)packages/extension/src/providers/polkadot/networks/polkadot.ts(1 hunks)packages/extension/src/providers/polkadot/networks/unique/opal.ts(1 hunks)packages/extension/src/providers/polkadot/networks/unique/quartz.ts(1 hunks)packages/extension/src/providers/polkadot/networks/unique/unique.ts(1 hunks)packages/extension/src/providers/polkadot/networks/vara.ts(1 hunks)packages/extension/src/providers/polkadot/networks/westend.ts(1 hunks)packages/extension/src/providers/solana/networks/solana.ts(1 hunks)packages/extension/src/ui/action/App.vue(12 hunks)
⛔ Files not processed due to max files limit (16)
- packages/extension/src/ui/action/components/accounts-header/index.vue
- packages/extension/src/ui/action/components/app-menu/components/app-menu-item.vue
- packages/extension/src/ui/action/components/app-menu/components/app-menu-tab.vue
- packages/extension/src/ui/action/components/app-menu/index.vue
- packages/extension/src/ui/action/components/base-search/index.vue
- packages/extension/src/ui/action/components/network-menu/index.vue
- packages/extension/src/ui/action/components/tooltip/index.vue
- packages/extension/src/ui/action/icons/actions/expand-menu.vue
- packages/extension/src/ui/action/main.ts
- packages/extension/src/ui/action/store/networks-store.ts
- packages/extension/src/ui/action/store/updates-store.ts
- packages/extension/src/ui/action/views/add-network/components/add-network-item.vue
- packages/extension/src/ui/action/views/add-network/index.vue
- packages/extension/src/ui/action/views/add-network/views/add-custom-network.vue
- packages/extension/src/ui/action/views/add-network/views/add-network-list.vue
- packages/extension/src/ui/action/views/updates/index.vue
🔇 Additional comments (114)
packages/extension/src/providers/ethereum/networks/aa.ts (1)
1-1: Icon Import Format Update.
The icon is now imported from a.webpfile instead of a.svgfile, which aligns with our new asset standardization. Please verify that the referenced file exists at the correct path.packages/extension/src/providers/ethereum/networks/manta-pacific.ts (1)
1-1: Updated Icon File Format.
The import now references a.webpfile in place of the earlier.pngformat. This change is consistent with our broader asset format update across the project.packages/extension/src/providers/ethereum/networks/maticzk.ts (1)
1-1: Streamlined Icon Import.
The icon import has been updated to use the.webpformat, supporting the initiative for improved performance and uniform asset management.packages/extension/src/providers/ethereum/networks/puppy.ts (1)
1-1: Consistent Image Asset Update.
The icon is now imported from a.webpfile instead of the legacy.svgformat. This revision maintains consistency with our standardization efforts across network providers.packages/extension/src/providers/ethereum/networks/aat.ts (1)
1-1: Asset Import Standardization.
The icon import has been switched to a.webpfile, matching the new project guidelines for image assets. Ensure that the new file path is correct and that the asset exists.packages/extension/src/providers/ethereum/networks/holesky.ts (1)
1-1: Icon Import Format Updated.
The icon is now imported from a WEBP file instead of an SVG, which aligns with the project’s effort to standardize on the WEBP format. This change is straightforward and does not affect any functionality.packages/extension/src/providers/ethereum/networks/form.ts (1)
1-1: Icon Import Format Updated.
The updated import now uses a WEBP file instead of a PNG, ensuring consistency with updates across other network configuration files.packages/extension/src/providers/solana/networks/solana.ts (1)
6-6: Updated Solana Icon Import.
The icon import is now using the WEBP format (sol.webp), which is in line with the new standard for network icons. The change is isolated to the import statement and correctly implemented.packages/extension/src/providers/ethereum/networks/ham.ts (1)
1-1: Icon Import Format Updated.
The icon now imports from a WEBP file (ham.webp) instead of a PNG, harmonizing with the rest of the project’s icon format updates.packages/extension/src/providers/ethereum/networks/edg.ts (1)
1-1: Icon Import Format Updated.
The icon for the Edgeware network is now imported from a WEBP file (edgeware.webp), which is consistent with similar updates in other network files. This change is simple and well-executed.packages/extension/src/providers/ethereum/networks/zksync.ts (2)
1-1: Icon Import Updated to WEBP
The import for the network icon has been changed to use a WEBP file. Please verify that the new WEBP asset exists at the specified path and meets performance and quality standards.
9-26: Network Options Consistency Check
The network configuration for zkSync is intact, with all endpoints and settings clearly defined. Ensure that these parameters—especially the block explorer URLs and node endpoint—are current and correctly reflect the zkSync network.packages/extension/src/providers/ethereum/networks/cagaAnkara.ts (2)
1-1: Updated Icon Import to WEBP
The icon import has been updated from a previous format (likely SVG) to WEBP. Confirm that the converted asset is optimized and available at the provided path.
6-21: Test Network Configuration Verification
The network configuration for CagaAnkara Testnet is structured as expected. Double-check that the URLs, chainID, and testnet flags align with the latest network documentation.packages/extension/src/providers/ethereum/networks/syscoin/rollux-testnet.ts (2)
1-1: Icon Import Updated to WEBP
The icon is now imported as a WEBP image, consistent with other recent updates. Ensure that the new WEBP icon is properly sized and optimized.
7-21: Rollux Test Network Configuration Review
The rolled-out network options for Syscoin ROLLUX Testnet are clear. Verify that properties such as the endpoint URLs, chainID, and additional fields like the buyLink are correct and up to date.packages/extension/src/providers/ethereum/networks/tlos.ts (2)
1-1: Icon Import Changed to WEBP
The icon import has been updated to load a WEBP file, which is in line with our asset format standardization. Please confirm that the new asset is valid and displays correctly in the UI.
8-24: Telos Network Configuration Validation
The Telos network options, including endpoint URLs, chainID, and related handlers, are correctly defined. It is also a good opportunity to double-check that the coingeckoID and associated platform data are accurate as per updated network documentation.packages/extension/src/providers/ethereum/networks/astr.ts (2)
1-1: Icon Import Updated from PNG to WEBP
The icon for the AstarEVM network has been updated from a PNG file to a WEBP file. Ensure that the WEBP version maintains visual quality and that the file is properly optimized for performance.
8-24: Astar Network Options Consistency
The configuration for AstarEVM is consistent with our network standards. Please verify that all endpoints, chainID, and handler integrations are correct and that the new coingecko platform identifier aligns with the Astar network’s specifications.packages/extension/src/providers/ethereum/networks/rsk-testnet.ts (1)
1-1: Icon Import Update is Correct
The icon is now imported from the WebP file (rootstock.webp), which is in line with the project’s push for improved asset optimization.packages/extension/src/providers/ethereum/networks/sepolia.ts (1)
1-1: WebP Icon Import Applied
The import of the Ethereum network icon now correctly points to the WebP file (eth.webp).packages/extension/src/providers/ethereum/networks/vic.ts (1)
1-1: Icon Update Confirmed
The icon import now uses the WebP file (viction.webp), which aligns with the project’s new asset format.packages/extension/src/providers/ethereum/networks/op.ts (1)
1-1: Icon Import Update is Appropriate
The updated import of the Optimism icon now references the WebP file (op.webp), which is correct.packages/extension/src/providers/ethereum/networks/op-bnb.ts (2)
1-1: Icon Format Transitioned Correctly
The icon is now imported from the WebP file (opbnb.webp), ensuring consistency with the asset format updates across the project.
24-24: Verify Activity Handler Implementation
TheactivityHandleris set as an inline lambda that returns a resolved empty array. Please confirm that this stub implementation is intentional and meets the integration requirements for the OpBNB network.packages/extension/src/providers/ethereum/networks/okc.ts (1)
1-1: Icon Import Updated to WebP Format
The import on line 1 has been updated from a previous format (e.g. SVG) to WebP (./icons/okc.webp), which is consistent with our asset standardization initiative. No further issues found.packages/extension/src/providers/ethereum/networks/glmr.ts (1)
1-1: Icon Import Change to WebP
Line 1 now imports the Moonbeam icon from a WebP file (./icons/moonbeam.webp). This update aligns with the overall effort to standardize icon formats across network configurations.packages/extension/src/providers/ethereum/networks/rari.ts (1)
1-1: Updated Icon Format from PNG to WebP
The icon import on line 1 has been modified to use a WebP asset (./icons/rari.webp). This change is straightforward and maintains consistency with similar updates across the project.packages/extension/src/providers/ethereum/networks/syscoin/nevm-testnet.ts (1)
1-1: Icon Import Revision to WebP
Line 1 now correctly imports the icon as a WebP file (../icons/tsys_nevm.webp), which is in line with our revised asset strategy.packages/extension/src/providers/ethereum/networks/mode.ts (1)
1-1: Icon Asset Format Updated to WebP
The update on line 1, changing the import to./icons/mode.webp, follows the standardized icon asset format used across network configurations. This ensures a consistent visual presentation across the application.packages/extension/src/providers/ethereum/networks/canto.ts (1)
1-1: Icon Import Updated to WEBP Format.
The import statement now loads the icon from a.webpfile (i.e.import icon from './icons/canto.webp';). This change is straightforward and aligns with the asset standardization across network configurations.packages/extension/src/providers/ethereum/networks/syscoin/nevm.ts (1)
1-1: Updated Icon Asset to WEBP Format.
The file now imports the icon from the updated WEBP asset (import icon from '../icons/sys_nevm.webp';). Please ensure that the referenced WEBP file exists and is optimized.packages/extension/src/providers/ethereum/networks/bsc.ts (1)
1-1: Consistent Asset Format Transition.
The BSC network configuration now uses a WEBP icon viaimport icon from './icons/bsc.webp';, ensuring consistency with recent refactors. This update does not affect functionality.packages/extension/src/providers/ethereum/networks/movr.ts (1)
1-1: WEBP Icon Update for MOVR Network.
The icon import has been updated from a SVG (presumably) to a WEBP format usingimport icon from './icons/moonriver.webp';. This change is aligned with the broader asset upgrade initiative.packages/extension/src/providers/ethereum/networks/celo.ts (1)
1-1: Icon Asset Format Standardization.
The update changes the import for the Celo network icon toimport icon from './icons/celo.webp';, which matches the overall approach in this PR. Confirm that the WEBP asset is available in the referenced path.packages/extension/src/providers/ethereum/networks/avax.ts (1)
1-1: Icon Format Update: The import statement on line 1 has been updated to loadavax.webpinstead of the older format (likely SVG). This change aligns well with the broader update across the project to standardize icon assets. Please ensure that the referencedavax.webpfile exists at the specified relative path.packages/extension/src/providers/ethereum/networks/shib.ts (1)
1-1: Icon Format Update: The icon is now imported from./icons/shiba-inu.webpas seen on line 1, which is consistent with the new standard across network configurations. No additional logic changes are required.packages/extension/src/providers/ethereum/networks/form-testnet.ts (1)
1-1: Icon Format Update: The icon import on line 1 now references./icons/form.webpinstead of the previous PNG format. This change contributes to a uniform asset format across network configurations. Verify that the file exists in the provided location.packages/extension/src/providers/ethereum/networks/linea.ts (1)
1-1: Icon Format Update: The asset for the Linea network has been updated on line 1 to use the newlinea.webpfile. This is consistent with the updated asset strategy. Ensure that the image file is present and rendered correctly in the UI.packages/extension/src/providers/ethereum/networks/etc.ts (1)
1-1: Icon Format Update: The icon import now references./icons/etc.webp(line 1) instead of the older SVG format. This update is part of the overall effort to standardize the icon formats and should help in asset loading efficiency. Please confirm the existence of the updated asset.packages/extension/src/providers/ethereum/networks/rsk.ts (1)
1-1: Icon Import Updated to WEBP
The Rootstock network icon now imports from a WEBP file (rootstock.webp), aligning the asset format with the project-wide updates for improved performance and consistency.packages/extension/src/providers/ethereum/networks/gno.ts (1)
1-1: Icon Format Update for Gnosis Network
The icon import has been updated from SVG to a WEBP file (gno.webp), ensuring consistency with the overall asset standardization effort.packages/extension/src/providers/ethereum/networks/forma.ts (1)
1-1: Updated Icon Import to WEBP
The Forma network now uses a WEBP icon (forma.webp) instead of the previous PNG format. This change supports better asset optimization across the codebase.packages/extension/src/providers/ethereum/networks/scroll.ts (1)
1-1: Consistent Asset Update to WEBP
The Scroll network icon is now imported from a WEBP file (scroll.webp), which is in line with the standardized icon format applied across multiple network configurations.packages/extension/src/providers/ethereum/networks/xlayer.ts (1)
1-1: Standardized Icon Import for XLayer
The import line has been updated to reference the WEBP icon (xlayer.webp) instead of the old PNG format. This supports the overall asset consistency and performance improvements throughout the project.packages/extension/src/providers/ethereum/networks/ontevm.ts (1)
1-1: Update import to use WebP for consistent asset formatsChanging the icon import to a WebP file (
ont-evm.webp) ensures uniformity with our new asset standards. This update is straightforward and does not impact functionality.packages/extension/src/providers/ethereum/networks/immutable-zkevm.ts (1)
1-1: Icon import updated to WebP formatThe icon is now imported as a WebP file (
immutable-zkevm.webp), which aligns with our efforts to standardize the asset formats across the codebase.packages/extension/src/providers/ethereum/networks/sdn.ts (1)
1-1: Updated icon format to WebPSwitching the icon to a WebP file (
sdn.webp) aligns with our overall image asset strategy. This change is minimal and helps maintain consistency across network configurations.packages/extension/src/providers/ethereum/networks/aurora.ts (1)
1-1: Consistent asset update for iconThe import has been updated to use a WebP version (
aurora.webp) instead of the PNG format, ensuring that our network assets remain consistent across different providers.packages/extension/src/providers/ethereum/networks/arb-nova.ts (1)
1-1: Switch icon import to WebP for improved consistencyUpdating the import from PNG to WebP (
arbitrum-nova.webp) guarantees a uniform asset format and may offer benefits in image performance and load times.packages/extension/src/providers/ethereum/networks/coti-devnet.ts (1)
1-1: Icon Import Updated to WEBP FormatThe import on line 1 now points to
coti.webpinstead of a PNG file. This change aligns with the standardized approach to using WEBP assets for improved performance and consistency.packages/extension/src/providers/ethereum/networks/degen.ts (1)
1-1: Changed Icon Format to WEBPThe icon import has been updated from a PNG to a WEBP file. The update is straightforward and does not impact any other logic. Maintaining consistent asset formats across network configuration files is a good practice.
packages/extension/src/providers/ethereum/networks/base.ts (1)
1-1: Updated Icon Asset to WEBPLine 1 now imports the icon from
base.webp, which is in line with the overall asset standardization initiative. There is no change to the functionality of the network configuration in this file.packages/extension/src/providers/ethereum/networks/eth.ts (1)
1-1: Icon Format Transition from SVG to WEBPThe change on line 1 updates the Ethereum icon import to use a WEBP file instead of an SVG. This adjustment should help in reducing asset size and improve load times while ensuring consistency across the project assets.
packages/extension/src/providers/ethereum/networks/zcd.ts (1)
1-1: Icon Import Updated from SVG to WEBPThe file now imports the ZChains icon from
zcd.webprather than a SVG file. This change is consistent with the other network configuration files and contributes to a uniform asset format across the project.packages/extension/src/providers/ethereum/networks/godwoken.ts (1)
1-1: Update Icon Import to WEBP Format
The import statement now correctly references thegodwoken.webpfile instead of a PNG, ensuring consistency with the new asset format across the project.packages/extension/src/providers/ethereum/networks/dmt.ts (1)
1-1: Icon Import Updated to WEBP Format
Line 1 has been updated to import the Sanko network icon as a WEBP file. This change harmonizes the asset format with similar updates in other network provider files.packages/extension/src/providers/ethereum/networks/pop-apex.ts (1)
1-1: Consistent Asset Update for Apex Icon
The updated import statement on line 1 now pulls in theapex.webpfile, aligning with the broader initiative of using WEBP images for network icons.packages/extension/src/providers/ethereum/networks/bitrock.ts (1)
1-1: Switch Icon to WEBP Format
Updating line 1 to importbitrock.webpis a straightforward, effective change that improves consistency and potentially reduces asset size compared to the previous SVG format.packages/extension/src/providers/ethereum/networks/karura.ts (1)
1-1: Standardize Icon Format to WEBP
The change on line 1 correctly updates the icon import to use a WEBP file (karura-evm.webp). This ensures a uniform asset format across network configurations without impacting overall functionality.packages/extension/src/providers/ethereum/networks/syscoin/rollux.ts (1)
1-1: Icon Import Update VerifiedThe asset import on line 1 was updated to use the WebP format (
sys_rollux.webp), which enhances image compression and consistency across similar modules. Ensure that all target browsers properly support WebP.packages/extension/src/providers/ethereum/types/custom-evm-network.ts (1)
4-4: Updated Icon Asset ReferenceThe icon import on line 4 now uses the WebP format (
eth.webp), maintaining consistency with recent asset management updates. This is a straightforward update with no side effects on the underlying logic.packages/extension/src/providers/ethereum/networks/arb.ts (1)
1-1: Consistent Icon Format UpdateThe icon imported on line 1 now references
arbitrum.webp, aligning with the standardization of asset formats across the project. There are no changes required in the consuming logic.packages/extension/src/providers/ethereum/networks/klay.ts (1)
1-1: Klaytn Icon Format UpdateThe change on line 1 updates the icon import to
klaytn.webp, which should deliver improved performance through better compression without affecting functionality.packages/extension/src/providers/ethereum/networks/skale/cryptoBlades.ts (1)
13-13: CryptoBlades Icon Format UpdatedThe icon property in the
skaleOptionsobject (line 13) now points toskaleCryptoBlades.webp, ensuring consistency with other network configurations and standardizing asset usage across the project.packages/extension/src/providers/ethereum/networks/skale/razor.ts (1)
13-13: Icon Format Updated to WEBP
Theiconproperty is now set to'skaleRazor.webp'instead of a PNG asset, aligning with the new asset standard. Please verify that the WEBP image is available at the expected path and renders correctly in the UI.packages/extension/src/providers/ethereum/networks/skale/calypso.ts (1)
13-13: Icon Format Updated to WEBP
The icon has been updated to'skaleCalypsoNFTHub.webp'to standardize image assets across the SKALE network configurations. Make sure that the new WEBP file is correctly placed and loaded in the application.packages/extension/src/providers/polkadot/networks/polkadot.ts (1)
9-9: Icon Import Updated to WEBP
The icon import has been changed to import the WebP asset ('./icons/polkadot.webp') instead of the previous format. This improves consistency across network assets. Please confirm the asset’s presence in the specified directory.packages/extension/src/providers/polkadot/networks/astar/shiden.ts (1)
11-11: Icon Import Updated to WEBP
Updated the icon import to use'../icons/shiden.webp'for the Shiden network configuration. This update ensures consistency with recent asset format changes. Verify that the corresponding asset is available and displays correctly.packages/extension/src/providers/bitcoin/networks/bitcoin-testnet.ts (1)
1-1: Icon Import Updated to WEBP
The Bitcoin Testnet icon is now imported from'./icons/tbtc.webp', following the standardized asset format update across the project. Please ensure that this WEBP asset is correctly hosted and renders as expected in the UI.packages/extension/src/providers/bitcoin/networks/litecoin.ts (1)
1-1: Icon Format Update for Litecoin
The import statement has been updated to reference a WEBP file (ltc.webp) instead of an SVG. This change is consistent with our asset optimization strategy and should reduce file size while maintaining quality.packages/extension/src/providers/polkadot/networks/vara.ts (1)
9-9: Icon Format Update for Vara Network
The icon import now uses a WEBP file (vara.webp), aligning with the new standardized asset format across providers. This change is straightforward and should improve loading performance with no impact on functionality.packages/extension/src/providers/bitcoin/networks/bitcoin.ts (1)
1-1: Icon Format Update for Bitcoin Network
The updated import of the Bitcoin icon now references a WEBP file (btc.webp), which is in line with our overall initiative to use optimized image assets. The update is clear and non-disruptive.packages/extension/src/providers/bitcoin/networks/dogecoin.ts (1)
1-1: Icon Format Update for Dogecoin
The import statement for the Dogecoin icon now correctly uses the WEBP file format (doge.webp), harmonizing asset usage with the rest of the project. This change is correctly implemented.packages/extension/src/providers/polkadot/networks/unique/opal.ts (1)
8-8: Icon Format Update for Opal Network
The icon for the Opal network is now imported from a WEBP file (opal.webp). This update meets the new standard for image assets across the project and is implemented in a clear and consistent manner.packages/extension/src/providers/polkadot/networks/unique/unique.ts (1)
9-9: Updated Icon Format Import
The import statement for the network icon has been updated to use the WebP format (unique.webp). This change is clear and aligns with the broader asset standardization in the project.packages/extension/src/providers/polkadot/networks/bifrost/polkadot.ts (1)
11-11: Updated Icon Import for Bifrost
The icon import on line 11 now referencesbifrost.webpinstead of the previous SVG. This update is consistent with the project-wide move to WebP assets and does not impact functionality.packages/extension/src/providers/polkadot/networks/acala/acala.ts (1)
11-11: Updated Icon Import for Acala
The icon import has been modified to point toacala.webprather than the older SVG format. This change ensures visual asset consistency across the network configurations.packages/extension/src/providers/ethereum/networks/skale/blockBrawlers.ts (1)
15-15: Updated Icon Assignment in Skale BlockBrawlers
The value for theiconproperty is now updated to useskaleBlockBrawlers.webpinstead of a PNG. This adjustment is straightforward and aligns with the new asset format standards adopted across the project.packages/extension/src/providers/ethereum/networks/5ire.ts (1)
1-1: Updated Icon Import for 5ire
The import statement on line 1 now fetches the WebP version (5ire.webp) of the icon. This update maintains consistency with the asset updates throughout the codebase and is implemented correctly.packages/extension/src/providers/ethereum/networks/skale/nebula.ts (1)
9-9: Update Nebula network icon to WEBP format.The
iconproperty now references"skaleNebula.webp", aligning with the standardized asset format across the project. Please verify that the referenced WEBP asset is available at the expected location.packages/extension/src/providers/polkadot/networks/westend.ts (1)
9-9: Switch Westend network icon import to WEBP.The import now points to
./icons/westend.webp, which is consistent with similar asset updates in the project. Ensure the new icon file is correctly sized and available.packages/extension/src/providers/polkadot/networks/pendulum/amplitude.ts (1)
9-9: Update Amplitude network icon to WEBP format.The icon import has been updated from an SVG to a WEBP file (
../icons/amplitude.webp), ensuring consistency with the new asset strategy. Confirm that the asset exists in the specified directory.packages/extension/src/providers/ethereum/networks/skale/exorde.ts (1)
9-9: Change Exorde network icon to WEBP.The
iconproperty now uses"skaleExorde.webp"instead of a PNG. This maintains consistency across SKALE network configurations. Please double-check the asset’s availability and resolution.packages/extension/src/providers/ethereum/networks/skale/titan.ts (1)
9-9: Update Titan network icon to WEBP format.The icon file is updated to
"skaleTitan.webp", in line with the standardized approach across network configurations. Verify that this asset is properly included in the repository.packages/extension/src/providers/polkadot/networks/unique/quartz.ts (1)
9-9: Icon Format Update for Quartz
The icon import has been updated to use the WEBP format (../icons/quartz.webp) instead of the previous format. This change aligns with the broader initiative to standardize icon formats across the project. Please verify that the referenced WEBP file exists in the expected location.packages/extension/src/providers/polkadot/networks/assethub/assethub-dot.ts (1)
12-12: Icon Format Update for Asset Hub DOT
The import for the network icon has been changed from a PNG file to a WEBP file (../icons/assethub.webp). This update is consistent with the project’s revised asset standards. Ensure that the new WEBP asset is present and renders correctly in the application.packages/extension/src/providers/ethereum/networks/skale/cryptoColosseum.ts (1)
13-13: Icon Format Update for SKALE Crypto Colosseum
The icon reference in the SKALE network configuration has been updated to use the WEBP format (skaleCryptoColloseum.webp) rather than a PNG. This change is straightforward and improves consistency across network assets. Please confirm the asset file’s availability.packages/extension/src/providers/polkadot/networks/edgeware.ts (1)
9-9: Icon Format Update for Edgeware
The edgeware icon import has been updated from a .svg (assumed previous format) to a WEBP file (./icons/edgeware.webp). This update does not impact functionality and follows the new asset guidelines. Please verify that the WEBP file is correctly located and displays as expected.packages/extension/src/providers/polkadot/networks/acala/assets/karura-assets.ts (1)
2-2: Icon Format Update for Karura
The Karura icon import has been updated from an SVG to a WEBP file (../../icons/karura.webp). This change is part of the overall effort to standardize icon assets. Confirm that the new WEBP asset is available in the designated directory and is rendered correctly.packages/extension/src/providers/ethereum/ui/wallet-add-ethereum-network.vue (1)
99-99: WEBP Icon Import Update for Ethereum Network
The import for the Ethereum icon has been updated from an SVG to a WEBP file. This change is aligned with the consolidation of icon formats across the project. Please verify that the file exists at the specified path and that the new format displays correctly in the UI.packages/extension/src/providers/ethereum/networks/skale/skale-base.ts (3)
18-18: Updated SKALE Fuel Icon Format
The import for the SKALE fuel icon now uses a WEBP file (../icons/skl-fuel.webp). This update ensures consistency with the new asset standard. Confirm that the new icon file exists and renders properly.
151-153: Fallback Icon for Preconfigured Tokens
The fallback icon now defaults to a WEBP image vianew URL('../icons/skl.webp', import.meta.url).href. This ensures that if no image is provided by the market data or asset configuration, a standardized icon is used. Please verify that the fallback order (market image, dynamic URL based on asset data, then fallback) is intended and that the fallback icon is available.
228-230: Dynamic Icon Resolution in SKALE Network Creation
Within thecreateSkaleEvmNetworkfunction, the network icon is now dynamically resolved using a WEBP file viaicon: new URL(`../icons/${params.icon ?? 'skl.webp'}`, import.meta.url).href,Ensure that when
params.iconis not provided, the fallback value (skl.webp) exists and correctly represents the network.packages/extension/src/providers/polkadot/networks/bifrost/assets/bifrost-assets.ts (1)
11-12: WEBP Icon Imports for Polkadot and Kusama
The imports for the Polkadot and Kusama icons have been updated to use WEBP files. This change supports the broader initiative to standardize asset formats across network assets. Verify that the new WEBP files are correctly referenced and rendered in the UI.packages/extension/src/providers/kadena/networks/kadena-testnet.ts (1)
6-6: Kadena Icon Format Update
The Kadena icon import has been changed from SVG to WEBP (./icons/kadena-kda-logo.webp). This enhances consistency with the new asset strategy. Please ensure that the WEBP icon is accessible and displays properly in all parts of the interface.packages/extension/src/providers/polkadot/networks/pendulum/assets/pendulum-assets.ts (1)
4-5: Updated Polkadot and Kusama Icons to WEBP
The imports foriconDotandiconKsmhave been updated to use WEBP files instead of SVG formats. This aligns with the standardized asset approach across multiple network modules. Confirm that these assets load correctly in the Pendulum network module and that no visual regressions occur.packages/extension/src/providers/ethereum/networks/skale/README.md (2)
33-33: Verify that "skl.webp" icon is available.
Consider verifying that the"skl.webp"file is actually present in thenetworks/iconsfolder to avoid broken image references.
49-49: Token icon default change looks good.
Switching the default token icon from.pngto.webpis fine if you have confirmed browser and build pipeline compatibility.packages/extension/src/ui/action/App.vue (14)
2-8: Good approach to dynamic classes.
This dynamic class binding is a neat way to toggle between collapsed, expanded, and locked states. No immediate issues found.
12-12: No concerns with the new condition.
Usingv-show="!isLoading"is straightforward and consistent with the rest of the template logic.
14-20: Confirm event emission fromapp-menu.
These new event bindings (@show:updates-dialog,@show:settings-dialog, etc.) rely onapp-menucorrectly emitting them. Double-check the child component’semitsdefinitions.
24-30: Nice dynamic content layout.
Applying conditional classes for expanded vs. collapsed states is well-organized. No issues found.
80-83: Ensure the updates modal is properly synced with store state.
Conditionally rendering the modal withv-if="updatesIsLoaded && showUpdatesDialog"aligns with the new updates store usage. No issues spotted.
97-97: New imports appear consistent.
ImportingDEFAULT_EVM_NETWORKandgetNetworkByNamefrom@/libs/utils/networksaligns with usage in the init method.
124-124: Metrics import usage.
Looks good for tracking user behavior and network transitions. Ensure correct parameters when callingtrackBuyEventsandtrackNetwork.
127-130: Store and metrics-type imports are well-structured.
These additions cleanly incorporate the updates store, networks store, and metrics types, promoting a modular setup.
134-134: No actual changes to review here.
165-166: New updates store usage.
PullingupdatesIsLoadedfrom the store viastoreToRefsis a straightforward approach for reactive store data.
169-171: Cascading logic when showing updates dialog.
UpdatinglastVersionViewedupon dialog open is a sensible way to track if users have seen the latest version information.
178-179: Network store initialization.
Integrating Pinia for network management mirrors the approach used for the updates store, promoting a unified state management pattern.
196-196: Potential null pointer access.
UsingselectedAccount!.addressmight cause runtime errors ifselectedAccountis null or undefined. Consider adding a null check or safe fallback.
235-235: Activating networks on init.
Ensuring the store is populated with active networks early in the lifecycle is sensible.
|
💼 Build Files |
…into feat/collapse-networks-menu
…nKrypt into feat/collapse-networks-menu
…nKrypt into feat/collapse-networks-menu
…nKrypt into feat/collapse-networks-menu
7 participants
Collapse Network Menu
New Network Icons
Summary by CodeRabbit