Skip to content

Revert "feat: add new networks"#653

Closed
gamalielhere wants to merge 16 commits intodevelopfrom
revert-638-devop/add-new-chains
Closed

Revert "feat: add new networks"#653
gamalielhere wants to merge 16 commits intodevelopfrom
revert-638-devop/add-new-chains

Conversation

@gamalielhere
Copy link
Contributor

@gamalielhere gamalielhere commented Mar 28, 2025

Reverts #638

Summary by CodeRabbit

  • Documentation

    • Revised the wallet’s supported chains list in the documentation to present a more focused set of blockchain networks.
  • New Features

    • Introduced new network support for Form, Rollux, SyscoinNEVM, and Fire, expanding available blockchain options.
  • Refactor

    • Streamlined network configurations by removing legacy options and endpoints, simplifying NFT and token management.

These updates provide a more targeted network selection and enhance overall clarity for the end-user experience.

@coderabbitai
Copy link

coderabbitai bot commented Mar 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request removes multiple blockchain network entries from configuration files, enums, and documentation while downgrading numerous dependency versions across various package.json files. Several network configuration files and export entries defining networks such as Gravity, Story, and others are deleted, and references to these networks are removed or updated. Additionally, the newNetworks array in one file is modified by removing old entries and adding four new ones. No changes to exported public entities are made.

Changes

File(s) Change Summary
README.md Removed several blockchain names from the "Currently Supported Chains" section.
Root package.json and multiple package JSON files (e.g. in packages/extension-bridge, packages/extension, packages/hw-wallets, packages/keyring, packages/name-resolution, packages/request, packages/signers/*, packages/storage, packages/swap, packages/types, packages/utils) Downgraded versions of various dependencies and devDependencies across the project.
packages/extension/src/libs/nft-handlers/simplehash.ts Removed network entries from the supportedNetworks object and adjusted formatting in the query construction.
packages/extension/src/providers/common/libs/new-features.ts Removed old network entries and added four new ones to the newNetworks array.
packages/extension/src/providers/ethereum/libs/activity-handlers/providers/etherscan/configs.ts Removed endpoints for NetworkNames.Ink and NetworkNames.Coti from the NetworkEndpoints object.
packages/extension/src/providers/ethereum/libs/assets-handlers/assetinfo-mew.ts Removed configuration for several networks and made minor formatting adjustments in the getTokens function.
packages/extension/src/providers/ethereum/libs/assets-handlers/types/tokenbalance-mew.ts Updated the SupportedNetworkNames type by removing multiple network names while retaining NetworkNames.Rari.
packages/extension/src/providers/ethereum/networks/celo.ts Added the assetsInfoHandler property to the celoOptions configuration.
Deleted network configuration files (e.g. abstract.ts, bera.ts, coti.ts, gravity.ts, inkonchain.ts, story.ts, taraxa.ts, unichain.ts) and updates in packages/extension/src/providers/ethereum/networks/index.ts Removed files and export entries defining configurations for several networks.
packages/types/src/networks.ts Removed multiple entries from the NetworkNames and CoingeckoPlatform enums.

Possibly related PRs

Suggested reviewers

  • kvhnuke
  • SemajaM8
  • NickKelly1

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01a1a96 and 58050a6.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (32)
  • README.md (0 hunks)
  • package.json (1 hunks)
  • packages/extension-bridge/package.json (1 hunks)
  • packages/extension/package.json (4 hunks)
  • packages/extension/src/libs/nft-handlers/simplehash.ts (1 hunks)
  • packages/extension/src/providers/common/libs/new-features.ts (1 hunks)
  • packages/extension/src/providers/ethereum/libs/activity-handlers/providers/etherscan/configs.ts (0 hunks)
  • packages/extension/src/providers/ethereum/libs/assets-handlers/assetinfo-mew.ts (1 hunks)
  • packages/extension/src/providers/ethereum/libs/assets-handlers/types/tokenbalance-mew.ts (1 hunks)
  • packages/extension/src/providers/ethereum/networks/abstract.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/bera.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/celo.ts (2 hunks)
  • packages/extension/src/providers/ethereum/networks/coti.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/gravity.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/index.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/inkonchain.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/story.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/taraxa.ts (0 hunks)
  • packages/extension/src/providers/ethereum/networks/unichain.ts (0 hunks)
  • packages/hw-wallets/package.json (2 hunks)
  • packages/keyring/package.json (1 hunks)
  • packages/name-resolution/package.json (2 hunks)
  • packages/request/package.json (1 hunks)
  • packages/signers/bitcoin/package.json (1 hunks)
  • packages/signers/ethereum/package.json (1 hunks)
  • packages/signers/kadena/package.json (1 hunks)
  • packages/signers/polkadot/package.json (1 hunks)
  • packages/storage/package.json (1 hunks)
  • packages/swap/package.json (1 hunks)
  • packages/types/package.json (1 hunks)
  • packages/types/src/networks.ts (0 hunks)
  • packages/utils/package.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

💼 Build Files
chrome: enkrypt-chrome-58050a67.zip
firefox: enkrypt-firefox-58050a67.zip

💉 Virus total analysis
chrome: 58050a67
firefox: 58050a67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants