Skip to content

Update Rootstock node url#661

Closed
ahsan-javaiid wants to merge 1 commit intoenkryptcom:devop/pakage-updatesfrom
ahsan-javaiid:fix/rsk-node
Closed

Update Rootstock node url#661
ahsan-javaiid wants to merge 1 commit intoenkryptcom:devop/pakage-updatesfrom
ahsan-javaiid:fix/rsk-node

Conversation

@ahsan-javaiid
Copy link
Contributor

@ahsan-javaiid ahsan-javaiid commented Apr 7, 2025

Description

This PR updates Rootstock node url to wss://nodes.mewapi.io/ws/rsk which uses RPC API.

Why

The public websocket url (wss://public-node.rsk.co/websocket) will be depricated in the favor of RPC API.

Summary by CodeRabbit

  • Chores
    • Updated the network connection settings for Rootstock to ensure improved performance and stability.

@coderabbitai
Copy link

coderabbitai bot commented Apr 7, 2025

Walkthrough

The change updates the Rootstock network provider by modifying the node property in the rootstockOptions object. The WebSocket endpoint value is changed from 'wss://public-node.rsk.co/websocket' to 'wss://nodes.mewapi.io/ws/rsk'. No other properties or public entities are altered.

Changes

File Change Summary
packages/extension/.../rsk.ts Updated the node property endpoint from 'wss://public-node.rsk.co/websocket' to 'wss://nodes.mewapi.io/ws/rsk' in the rootstockOptions object.

Suggested reviewers

  • kvhnuke
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/extension/src/providers/ethereum/networks/rsk.ts (1)

23-23: URL update looks good, but could benefit from a comment explaining the change.

The Rootstock node URL has been updated from the deprecated websocket endpoint to the new RPC API endpoint as specified in the PR objectives. This change is necessary to ensure continued functionality as the old endpoint is being deprecated.

Consider adding a comment to explain why this URL was changed, to provide context for future maintainers:

- node: 'wss://nodes.mewapi.io/ws/rsk',
+ // Updated from wss://public-node.rsk.co/websocket due to deprecation - see https://docs.rootstock.io/
+ node: 'wss://nodes.mewapi.io/ws/rsk',
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88b1888 and f72341a.

📒 Files selected for processing (1)
  • packages/extension/src/providers/ethereum/networks/rsk.ts (1 hunks)
🔇 Additional comments (1)
packages/extension/src/providers/ethereum/networks/rsk.ts (1)

1-45: Have you verified that the new endpoint is working correctly?

Since this change involves switching to a different node endpoint, it would be important to verify that the application can successfully connect to and operate with this new endpoint.

Could you confirm that you've tested the application with this new Rootstock node URL to ensure it's working correctly? This would involve checking that:

  1. The application can establish a connection to the node
  2. Standard operations (querying balances, sending transactions, etc.) work as expected
  3. There are no unexpected errors or performance issues with the new endpoint

@kvhnuke kvhnuke changed the base branch from main to devop/pakage-updates April 8, 2025 17:46
@kvhnuke
Copy link
Contributor

kvhnuke commented Apr 8, 2025

included in #637

@kvhnuke kvhnuke closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments