Update Rootstock node url#661
Update Rootstock node url#661ahsan-javaiid wants to merge 1 commit intoenkryptcom:devop/pakage-updatesfrom
Conversation
WalkthroughThe change updates the Rootstock network provider by modifying the Changes
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/extension/src/providers/ethereum/networks/rsk.ts (1)
23-23: URL update looks good, but could benefit from a comment explaining the change.The Rootstock node URL has been updated from the deprecated websocket endpoint to the new RPC API endpoint as specified in the PR objectives. This change is necessary to ensure continued functionality as the old endpoint is being deprecated.
Consider adding a comment to explain why this URL was changed, to provide context for future maintainers:
- node: 'wss://nodes.mewapi.io/ws/rsk', + // Updated from wss://public-node.rsk.co/websocket due to deprecation - see https://docs.rootstock.io/ + node: 'wss://nodes.mewapi.io/ws/rsk',
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/extension/src/providers/ethereum/networks/rsk.ts(1 hunks)
🔇 Additional comments (1)
packages/extension/src/providers/ethereum/networks/rsk.ts (1)
1-45: Have you verified that the new endpoint is working correctly?Since this change involves switching to a different node endpoint, it would be important to verify that the application can successfully connect to and operate with this new endpoint.
Could you confirm that you've tested the application with this new Rootstock node URL to ensure it's working correctly? This would involve checking that:
- The application can establish a connection to the node
- Standard operations (querying balances, sending transactions, etc.) work as expected
- There are no unexpected errors or performance issues with the new endpoint
|
included in #637 |
Description
This PR updates Rootstock node url to
wss://nodes.mewapi.io/ws/rskwhich uses RPC API.Why
The public websocket url (wss://public-node.rsk.co/websocket) will be depricated in the favor of RPC API.
Summary by CodeRabbit