[FIX] Total balance not updated when withdrawal completes#701
Closed
ahsan-javaiid wants to merge 1 commit intoenkryptcom:developfrom
Closed
[FIX] Total balance not updated when withdrawal completes#701ahsan-javaiid wants to merge 1 commit intoenkryptcom:developfrom
ahsan-javaiid wants to merge 1 commit intoenkryptcom:developfrom
Conversation
WalkthroughAn event handler for the 'receipt' event was added to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant VueComponent
participant web3
participant Router
User->>VueComponent: Initiate sendAction
VueComponent->>web3: sendSignedTransaction
web3-->>VueComponent: transactionHash event
web3-->>VueComponent: receipt event
VueComponent->>Router: router.go(0) (reload page)
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
packages/extension/src/providers/ethereum/ui/send-transaction/verify-transaction/index.vue
Show resolved
Hide resolved
Contributor
|
@ahsan-javaiid this interferes with some of the other logic thats why we had to revert it, we are aware of this issue and will figure out a way to fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of total balance not refreshing after tx confirms. Due to this issue the individual and total balances does not match. When the withdrawal is processed, it is needed to refresh in order to see the total balance update.
Tested this on couple of EVM chains, it's happening on all EVM chains.
Snapshots
Summary by CodeRabbit