Skip to content

devop: export types#740

Merged
kvhnuke merged 3 commits intodevop/package-upgrades-2-11from
devop/export-types
Aug 27, 2025
Merged

devop: export types#740
kvhnuke merged 3 commits intodevop/package-upgrades-2-11from
devop/export-types

Conversation

@kvhnuke
Copy link
Contributor

@kvhnuke kvhnuke commented Aug 13, 2025

Summary by CodeRabbit

  • Chores

    • Added a swap-related type to the public API for improved TypeScript/IDE ergonomics (no runtime or UI changes).
  • Bug Fixes

    • Removed Form and Form Testnet from the extension’s Ethereum network list and related endpoints — these networks are no longer selectable.
    • Removed Binance and Matic from the gas estimation support list — gas estimates for those networks will no longer be provided.

@kvhnuke kvhnuke changed the title devop: export type devop: export types Aug 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Walkthrough

Removes Form and FormTestnet network definitions and references across the extension, and adds a public re-export for the ToTokenType type from the swap package. No runtime logic changes beyond network removal and export exposure. (≤50 words)

Changes

Cohort / File(s) Summary of Changes
Swap public exports
packages/swap/src/index.ts
Added public re-export of type ToTokenType (present in two export blocks). No runtime logic changes.
Etherscan endpoints config
packages/extension/src/providers/ethereum/libs/activity-handlers/providers/etherscan/configs.ts
Removed NetworkNames.FormTestnet and NetworkNames.Form entries from the NetworkEndpoints mapping.
Removed network modules
packages/extension/src/providers/ethereum/networks/form-testnet.ts, packages/extension/src/providers/ethereum/networks/form.ts
Deleted modules that defined and exported the Form Testnet and Form mainnet EvmNetwork instances; their exports and instances were removed.
Networks index mapping
packages/extension/src/providers/ethereum/networks/index.ts
Removed imports and default-export properties for formTestnet and form from the networks registry.
Network names enum
packages/types/src/networks.ts
Removed FormTestnet and Form members from the NetworkNames enum.
Gas estimate networks
packages/swap/src/common/estimateGasList.ts
Removed Binance and Matic entries from the supportedNetworks mapping used for gas estimation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

Possibly related PRs

Suggested reviewers

  • gamalielhere
  • olgakup
  • SemajaM

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 926c79a and 3bc16b3.

📒 Files selected for processing (1)
  • packages/swap/src/common/estimateGasList.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/swap/src/common/estimateGasList.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: buildAll
  • GitHub Check: test
  • GitHub Check: test
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devop/export-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Aug 13, 2025

💼 Build Files
chrome: enkrypt-chrome-3bc16b3e.zip
firefox: enkrypt-firefox-3bc16b3e.zip

💉 Virus total analysis
chrome: 3bc16b3e
firefox: 3bc16b3e

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/swap/src/index.ts (1)

270-271: Optional: Mark ToTokenType as a type-only export for future-proofing.

If you use (or plan to enable) TypeScript’s verbatimModuleSyntax/preserveValueImports, explicitly exporting as a type avoids potential tooling friction.

Apply this minimal change:

-  ToTokenType,
+  type ToTokenType,
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f85baf and ed340c7.

📒 Files selected for processing (1)
  • packages/swap/src/index.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: buildAll
  • GitHub Check: test
  • GitHub Check: test
🔇 Additional comments (1)
packages/swap/src/index.ts (1)

270-271: LGTM: Publicly exporting ToTokenType is correct and consistent with existing patterns.

This aligns with how other types are exposed from this module and introduces no runtime impact.

@kvhnuke kvhnuke changed the base branch from develop to devop/package-upgrades-2-11 August 27, 2025 18:10
@kvhnuke kvhnuke merged commit da2e374 into devop/package-upgrades-2-11 Aug 27, 2025
5 checks passed
@kvhnuke kvhnuke deleted the devop/export-types branch August 27, 2025 18:10
@coderabbitai coderabbitai bot mentioned this pull request Aug 27, 2025
This was referenced Sep 10, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant