Add support for TFUEL addresses #184
Conversation
Echolon166
force-pushed
the
tfuel_support
branch
from
822c765 to
cd9cf96
Compare
|
Updated PR fixes the incorrect ordering in README. |
|
Hi, I tried to resolve the conflict of this and the test failed again. Would you mind fixing this and also resolve conflicts of all the others you have submitted so that I can priortise your PR? |
|
@makoto I've resolved the conflicts of my PR's. |
src/__tests__/index.test.ts
Outdated
| }, | ||
| { | ||
| name: 'TFUEL', | ||
| coinType: 570, |
There was a problem hiding this comment.
Is this correct coin type? 570 is allocated to BDX according to https://github.com/satoshilabs/slips/blob/master/slip-0044.md
There was a problem hiding this comment.
I've opened a PR to add TFUEL to SLIP-0044: satoshilabs/slips#1024
I will update this PR according to it when it finalizes.
src/index.ts
Outdated
| bitcoinBase58Chain('CCA', 489, [[0x0b]], [[0x05]]), | ||
| getConfig('SOL', 501, bs58EncodeNoCheck, bs58DecodeNoCheck), | ||
| bitcoinBase58Chain('LRG', 568, [[0x1e]], [[0x0d]]), | ||
| hexChecksumChain('TFUEL', 570), |
There was a problem hiding this comment.
Is this correct coin type? 570 is allocated to BDX according to https://github.com/satoshilabs/slips/blob/master/slip-0044.md
|
Are there any block explorer for TFUEL? I want to double check that they are actually just using hex checksum |
TFUEL uses the same explorer along with Theta token: https://explorer.thetatoken.org/ |
|
FYI, we have PR for THETA https://github.com/ensdomains/address-encoder/pull/125/files but implementation looks different. Are either of PR wrong or did the implementation change? |
We're both using the hexChecksumChain, so there's no practical difference. Seems like he just added some padding all around, for some reason. I've updated the coin type. |
3 participants
Issue number
Closes #159
Description
Add support for TFUEL addresses, which uses the same address with Theta.
References
Checklist: