Skip to content

Better Silverstripe detection #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanhamlin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Better Silverstripe detection #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/technologies/s.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3124,7 +3124,15 @@
1
],
"description": "Silverstripe CMS is a free and open source Content Management System and Framework for creating and maintaining websites and web applications.",
"html": "Powered by <a href=\"[^>]+Silverstripe",
"dom": [
"link[href*='silverstripe']",
"link[href^='/_resources/app/client/dist/']",
"link[href^='/assets/_combinedfiles/resources/']"
],
"html": [
"Powered by <a href=\"[^>]+SilverStripe",
"<link [^>]*href=\\\"/?_?resources/(themes|vendor)/.*\\.css\\?m=\\d{10}"
Copy link
Contributor

@kingthorin kingthorin May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I'd just suggest making the themes bit non-capturing.

Copy link
Member

@enthec-opensource enthec-opensource May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe the second element in the html array is a bit generic
2nd dom aswell?

Copy link
Contributor

@kingthorin kingthorin May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

],
"icon": "SilverStripe.svg",
"implies": "PHP",
"meta": {
Expand Down