Tests fail with Python 3.11: AttributeError: 'NoneType' object has no attribute 'pop'

[s3v-]

Some tests start failing with Python 3.11.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027503

> ======================================================================
> ERROR: Test the get_version function.
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/tests/test_version_registry.py", line 69, in test_get_version
>     state = state_pickler.get_state(c)
>             ^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 996, in get_state
>     s = dumps(obj)
>         ^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 968, in dumps
>     return StatePickler().dumps(value)
>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 308, in dumps
>     return pickle.dumps(self._do(value))
>                         ^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 358, in _do
>     return self._do_instance(obj)
>            ^^^^^^^^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 403, in _do_instance
>     state.pop("__traits_version__", None)
>     ^^^^^^^^^
> AttributeError: 'NoneType' object has no attribute 'pop'
> 
> ======================================================================
> ERROR: Test if update method calls the handlers in order.
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/tests/test_version_registry.py", line 111, in test_update
>     state = state_pickler.get_state(c)
>             ^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 996, in get_state
>     s = dumps(obj)
>         ^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 968, in dumps
>     return StatePickler().dumps(value)
>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 308, in dumps
>     return pickle.dumps(self._do(value))
>                         ^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 358, in _do
>     return self._do_instance(obj)
>            ^^^^^^^^^^^^^^^^^^^^^^
>   File "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_apptools/build/apptools/persistence/state_pickler.py", line 403, in _do_instance
>     state.pop("__traits_version__", None)
>     ^^^^^^^^^
> AttributeError: 'NoneType' object has no attribute 'pop'
> 
> ----------------------------------------------------------------------
> Ran 355 tests in 1.754s
> 
> FAILED (errors=2)

Please note that every pyckable object has _getstate_ method in Python 3.11
https://docs.python.org/3/library/pickle.html#object.__getstate__
As a consequence, "else" statement is never hitted in this cycle:

apptools/apptools/persistence/state_pickler.py

Lines 395 to 401 in 127fe9f

	# Get the object state.
	if hasattr(value, "__get_pure_state__"):
	state = value.__get_pure_state__()
	elif hasattr(value, "__getstate__"):
	state = value.__getstate__()
	else:
	state = value.__dict__

Kind Regards

[emollier]

Hi, I added the following fix workaround for python3.11 on Debian salsa; also uploaded.

Hope this helps,
Étienne.

[mdickinson]

Thanks for the report. We're planning some maintenance on apptools in the near-ish future, and that will include getting things back to working on Python 3.11.

[mdickinson]

For reference, the relevant change in CPython was this one: python/cpython#2821